ODBC cleanup

Started by Bruce Momjianabout 25 years ago5 messagespatches
Jump to latest
#1Bruce Momjian
bruce@momjian.us

I have been sitting on my ODBC source code cleanup patch for a while.
Now that we are in 7.2, does anyone have outstanding ODBC patches before
I apply this? Hiroshi, did you apply yours already?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#2Hiroshi Inoue
Inoue@tpf.co.jp
In reply to: Bruce Momjian (#1)
Re: ODBC cleanup

Bruce Momjian wrote:

I have been sitting on my ODBC source code cleanup patch for a while.
Now that we are in 7.2, does anyone have outstanding ODBC patches before
I apply this? Hiroshi, did you apply yours already?

I would commit another change([ODBC] A proposal to change psqlodbc)
in a week or so but I have no patch right now.

regards,
Hiroshi Inoue

#3Bruce Momjian
bruce@momjian.us
In reply to: Hiroshi Inoue (#2)
Re: ODBC cleanup

Bruce Momjian wrote:

I have been sitting on my ODBC source code cleanup patch for a while.
Now that we are in 7.2, does anyone have outstanding ODBC patches before
I apply this? Hiroshi, did you apply yours already?

I would commit another change([ODBC] A proposal to change psqlodbc)
in a week or so but I have no patch right now.

Have you modified your copy of ODBC there, or is this something you will
start working on in a few days?

My patch will just remove some blank space and align some defines. It
will not affect the code's function. As long as you are not sitting on
ODBC changes right now it should be OK. The patch will make the ODBC
look more like the rest of our C code.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#4Hiroshi Inoue
Inoue@tpf.co.jp
In reply to: Bruce Momjian (#3)
Re: ODBC cleanup

Bruce Momjian wrote:

Bruce Momjian wrote:

I have been sitting on my ODBC source code cleanup patch for a while.
Now that we are in 7.2, does anyone have outstanding ODBC patches before
I apply this? Hiroshi, did you apply yours already?

I would commit another change([ODBC] A proposal to change psqlodbc)
in a week or so but I have no patch right now.

Have you modified your copy of ODBC there, or is this something you will
start working on in a few days?

My local copy is the same as cvs now.
Your change has no problem for me.

regards,
Hiroshi inoue

#5Bruce Momjian
bruce@momjian.us
In reply to: Hiroshi Inoue (#4)
Re: ODBC cleanup

Bruce Momjian wrote:

Bruce Momjian wrote:

I have been sitting on my ODBC source code cleanup patch for a while.
Now that we are in 7.2, does anyone have outstanding ODBC patches before
I apply this? Hiroshi, did you apply yours already?

I would commit another change([ODBC] A proposal to change psqlodbc)
in a week or so but I have no patch right now.

Have you modified your copy of ODBC there, or is this something you will
start working on in a few days?

My local copy is the same as cvs now.
Your change has no problem for me.

OK, I will wait until tomorrow to give others time to object and then
apply it. You will see the commit meesage. Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026