Cygwin PostgreSQL Python Module Patch

On Fri, May 11, 2001 at 11:30:30AM -0400, Jason Tishler wrote:

See attached for a minor patch that enables the PostgreSQL Python Module
to build cleanly under Cygwin.

I was hoping that this one could be sneaked into 7.1.2. Unfortunately,
the following seems to indicate that I just missed the cut off:

http://fts.postgresql.org/db/mw/msg.html?mid=118227

If I didn't miss the cut off, can it be considered for 7.1.2?

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

To be in 7.1.X, it would have to be a big bug and the patch of low risk.

On Fri, May 11, 2001 at 11:30:30AM -0400, Jason Tishler wrote:

See attached for a minor patch that enables the PostgreSQL Python Module
to build cleanly under Cygwin.

I was hoping that this one could be sneaked into 7.1.2. Unfortunately,
the following seems to indicate that I just missed the cut off:

http://fts.postgresql.org/db/mw/msg.html?mid=118227

If I didn't miss the cut off, can it be considered for 7.1.2?

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce,

On Wed, May 16, 2001 at 06:11:18PM -0400, Bruce Momjian wrote:

To be in 7.1.X, it would have to be a big bug and the patch of low risk.

I guess that I met the second criterion but not the first. Nevertheless,
the policy is very reasonable and acceptable. I've managed to avoid
maintaining a patch list up until now -- oh, well...

BTW, I'm very impressed by the the PostgreSQL development process
and IMHO it is a role model for the open source community.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

Bruce,

On Wed, May 16, 2001 at 06:11:18PM -0400, Bruce Momjian wrote:

To be in 7.1.X, it would have to be a big bug and the patch of low risk.

I guess that I met the second criterion but not the first. Nevertheless,
the policy is very reasonable and acceptable. I've managed to avoid
maintaining a patch list up until now -- oh, well...

We added to bugs in 7.1.1 that were not in 7.1, so we are being pretty
careful for 7.1.2.

BTW, I'm very impressed by the the PostgreSQL development process
and IMHO it is a role model for the open source community.

Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it withing the next 48 hours.

See attached for a minor patch that enables the PostgreSQL Python Module
to build cleanly under Cygwin.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

-- Start of included mail From: Jason Tishler <Jason.Tishler@dothill.com>

Date: Fri, 11 May 2001 11:26:13 -0400
To: Ernesto Revilla <aerd@retemail.es>
cc: pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
bcc: jt+misc.copy@ny.dothill.com
Subject: Re: Perl + Python Postgresql 7.1.1 under Cygwin
Mail-Followup-To: Ernesto Revilla <aerd@retemail.es>,
pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
Content-Disposition: inline
User-Agent: Mutt/1.3.18i
Organization: Dot Hill Systems Corp.

Erny,

On Fri, May 11, 2001 at 01:21:07AM +0200, Ernesto Revilla wrote:

For the Python interface to compile, I had to add the -DMS_WIN32 in the
Makefile.pre.in . If not a 'not constant type' happens in pgmodule.c line
951. I don't know if there is a better place tu put the def. After this it
compiles and seems to work well. I used Python 2.1.

While changing Cygwin Python to build its core as a DLL (like Win32
Python) to support shared extension modules, I have learned that Guido
prefers the style of the attached patch to solve the above problem.
I feel that this solution is particularly appropriate in this case
because the following:

PglargeType
PgType
PgQueryType

are already being handled in the way that I am proposing for PgSourceType.

I will submit this patch to pgsql-patches for consideration.

Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]
-- End of included mail.

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Patch applied. Thanks.

See attached for a minor patch that enables the PostgreSQL Python Module
to build cleanly under Cygwin.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

-- Start of included mail From: Jason Tishler <Jason.Tishler@dothill.com>

Date: Fri, 11 May 2001 11:26:13 -0400
To: Ernesto Revilla <aerd@retemail.es>
cc: pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
bcc: jt+misc.copy@ny.dothill.com
Subject: Re: Perl + Python Postgresql 7.1.1 under Cygwin
Mail-Followup-To: Ernesto Revilla <aerd@retemail.es>,
pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
Content-Disposition: inline
User-Agent: Mutt/1.3.18i
Organization: Dot Hill Systems Corp.

Erny,

On Fri, May 11, 2001 at 01:21:07AM +0200, Ernesto Revilla wrote:

For the Python interface to compile, I had to add the -DMS_WIN32 in the
Makefile.pre.in . If not a 'not constant type' happens in pgmodule.c line
951. I don't know if there is a better place tu put the def. After this it
compiles and seems to work well. I used Python 2.1.

While changing Cygwin Python to build its core as a DLL (like Win32
Python) to support shared extension modules, I have learned that Guido
prefers the style of the attached patch to solve the above problem.
I feel that this solution is particularly appropriate in this case
because the following:

PglargeType
PgType
PgQueryType

are already being handled in the way that I am proposing for PgSourceType.

I will submit this patch to pgsql-patches for consideration.

Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]
-- End of included mail.

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026