Cygwin contrib patch

Started by Jason Tishlerabout 25 years ago8 messagespatches
Jump to latest
#1Jason Tishler
Jason.Tishler@dothill.com

The attached patch enables the contrib subtree to build cleanly under
Cygwin with the possible exception of mSQL-interface. Since I don't
have mSQL installed, I skipped this tool.

Except for dealing with a missing getopt.h (oid2name) and HUGE (seg),
the bulk of the patch uses the standard PostgreSQL approach to deal with
Windows DLL issues.

I tested the build aspect of this patch under Cygwin and Linux without
any ill affects. Note that I did not actually attempt to test the code
for functionality.

The procedure to apply the patch is as follows:

$ # save the attachment as /tmp/contrib.patch
$ # change directory to the top of the PostgreSQL source tree
$ patch -p0 </tmp/contrib.patch

Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

Attachments:

contrib.patchtext/plain; charset=us-asciiDownload+24-4
#2Bruce Momjian
bruce@momjian.us
In reply to: Jason Tishler (#1)
Re: [PATCHES] Cygwin contrib patch

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

The attached patch enables the contrib subtree to build cleanly under
Cygwin with the possible exception of mSQL-interface. Since I don't
have mSQL installed, I skipped this tool.

Except for dealing with a missing getopt.h (oid2name) and HUGE (seg),
the bulk of the patch uses the standard PostgreSQL approach to deal with
Windows DLL issues.

I tested the build aspect of this patch under Cygwin and Linux without
any ill affects. Note that I did not actually attempt to test the code
for functionality.

The procedure to apply the patch is as follows:

$ # save the attachment as /tmp/contrib.patch
$ # change directory to the top of the PostgreSQL source tree
$ patch -p0 </tmp/contrib.patch

Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Bruce Momjian
bruce@momjian.us
In reply to: Jason Tishler (#1)
Re: [PATCHES] Cygwin contrib patch

Patch applied. I manually updated dblink because it was too new for
your patch.

The attached patch enables the contrib subtree to build cleanly under
Cygwin with the possible exception of mSQL-interface. Since I don't
have mSQL installed, I skipped this tool.

Except for dealing with a missing getopt.h (oid2name) and HUGE (seg),
the bulk of the patch uses the standard PostgreSQL approach to deal with
Windows DLL issues.

I tested the build aspect of this patch under Cygwin and Linux without
any ill affects. Note that I did not actually attempt to test the code
for functionality.

The procedure to apply the patch is as follows:

$ # save the attachment as /tmp/contrib.patch
$ # change directory to the top of the PostgreSQL source tree
$ patch -p0 </tmp/contrib.patch

Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#4Jason Tishler
Jason.Tishler@dothill.com
In reply to: Bruce Momjian (#3)
Re: [PATCHES] Cygwin contrib patch

Bruce,

On Mon, Jun 18, 2001 at 05:38:19PM -0400, Bruce Momjian wrote:

Patch applied.

Thanks.

I manually updated dblink because it was too new for your patch.

Actually, I forgot to supply the "-d" option to cvs update -- just like
I usually do. Sigh...

Attached is a patch to deal with the ones that I missed the first time
around. I tested this patch under Cygwin and Linux.

Note that I only changed dblink's Makefile in the most minimal way
to fix the link problem under Cygwin (i.e., use the link rule from
Makefile.shlib instead). dblink's Makefile should probably be further
patched to be consistent with the other PostgreSQL Makefiles.

The procedure to apply the patch is as follows:

$ # save the attachment as /tmp/contrib2.patch
$ cd contrib
$ patch -p0 </tmp/contrib2.patch

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

Attachments:

contrib2.patchtext/plain; charset=us-asciiDownload+6-4
#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Jason Tishler (#4)
Re: [PATCHES] Cygwin contrib patch

Jason Tishler <Jason.Tishler@dothill.com> writes:

Actually, I forgot to supply the "-d" option to cvs update -- just like
I usually do. Sigh...

Tip: you can make cvs' default behavior a little saner by setting up a
~/.cvsrc file. Mine is

cvs -z3
update -d -P
checkout -P

regards, tom lane

#6Bruce Momjian
bruce@momjian.us
In reply to: Jason Tishler (#4)
Re: [PATCHES] Cygwin contrib patch

Thanks. Patch applied.

Bruce,

On Mon, Jun 18, 2001 at 05:38:19PM -0400, Bruce Momjian wrote:

Patch applied.

Thanks.

I manually updated dblink because it was too new for your patch.

Actually, I forgot to supply the "-d" option to cvs update -- just like
I usually do. Sigh...

Attached is a patch to deal with the ones that I missed the first time
around. I tested this patch under Cygwin and Linux.

Note that I only changed dblink's Makefile in the most minimal way
to fix the link problem under Cygwin (i.e., use the link rule from
Makefile.shlib instead). dblink's Makefile should probably be further
patched to be consistent with the other PostgreSQL Makefiles.

The procedure to apply the patch is as follows:

$ # save the attachment as /tmp/contrib2.patch
$ cd contrib
$ patch -p0 </tmp/contrib2.patch

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7Jason Tishler
Jason.Tishler@dothill.com
In reply to: Tom Lane (#5)
Re: [PATCHES] Cygwin contrib patch

Tom,

On Tue, Jun 19, 2001 at 02:44:52PM -0400, Tom Lane wrote:

Jason Tishler <Jason.Tishler@dothill.com> writes:

Actually, I forgot to supply the "-d" option to cvs update -- just like
I usually do. Sigh...

Tip: you can make cvs' default behavior a little saner by setting up a
~/.cvsrc file. Mine is

cvs -z3
update -d -P
checkout -P

Thanks for the tip. Unfortunately, this means that I can't use the "I
forgot the -d option" excuse anymore. :,)

Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

#8Bruce Momjian
bruce@momjian.us
In reply to: Jason Tishler (#7)
Re: [PATCHES] Cygwin contrib patch

Tom,

On Tue, Jun 19, 2001 at 02:44:52PM -0400, Tom Lane wrote:

Jason Tishler <Jason.Tishler@dothill.com> writes:

Actually, I forgot to supply the "-d" option to cvs update -- just like
I usually do. Sigh...

Tip: you can make cvs' default behavior a little saner by setting up a
~/.cvsrc file. Mine is

cvs -z3
update -d -P
checkout -P

Thanks for the tip. Unfortunately, this means that I can't use the "I
forgot the -d option" excuse anymore. :,)

I have a few other CVS excuses. Email me privately. :-)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026