Patch for JDBC to update some comments

Started by Barry Lindalmost 25 years ago3 messagespatches
Jump to latest
#1Barry Lind
barry@xythos.com

This patch updates some comments in the DatabaseMetaData classes to
reflect a mail thread that discussed our conformance (or lack thereof)
to the SQL92 spec.

thanks,
--Barry

Attachments:

patch.difftext/plain; name=patch.diffDownload+30-30
#2Bruce Momjian
bruce@momjian.us
In reply to: Barry Lind (#1)
Re: Patch for JDBC to update some comments

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

This patch updates some comments in the DatabaseMetaData classes to
reflect a mail thread that discussed our conformance (or lack thereof)
to the SQL92 spec.

thanks,
--Barry

*** ./interfaces/jdbc/org/postgresql/jdbc1/DatabaseMetaData.java.orig	Sat Aug  4 12:32:04 2001
--- ./interfaces/jdbc/org/postgresql/jdbc1/DatabaseMetaData.java	Wed Aug 15 22:39:55 2001
***************
*** 680,686 ****
/**
* Does this driver support the ANSI-92 entry level SQL grammar?
!    * All JDBC Compliant drivers must return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 680,691 ----

/**
* Does this driver support the ANSI-92 entry level SQL grammar?
! * All JDBC Compliant drivers must return true. We currently
! * report false until 'schema' support is added. Then this
! * should be changed to return true, since we will be mostly
! * compliant (probably more compliant than many other databases)
! * And since this is a requirement for all JDBC drivers we
! * need to get to the point where we can return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 726,732 ****
}

/**
!    * Is some form of outer join supported?  From my knowledge, nope.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 731,737 ----
}

/**
! * Is some form of outer join supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 737,744 ****
}

/**
!    * Are full nexted outer joins supported?  Well, we dont support any
!    * form of outer join, so this is no as well
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 742,748 ----
}

/**
! * Are full nexted outer joins supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 749,756 ****
}

/**
!    * Is there limited support for outer joins?  (This will be true if
!    * supportFullOuterJoins is true)
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 753,759 ----
}
/**
!    * Is there limited support for outer joins?
*
* @return true if so
* @exception SQLException if a database access error occurs
*** ./interfaces/jdbc/org/postgresql/jdbc2/DatabaseMetaData.java.orig	Wed Aug 15 22:25:44 2001
--- ./interfaces/jdbc/org/postgresql/jdbc2/DatabaseMetaData.java	Wed Aug 15 22:37:10 2001
***************
*** 680,686 ****
/**
* Does this driver support the ANSI-92 entry level SQL grammar?
!    * All JDBC Compliant drivers must return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 680,691 ----

/**
* Does this driver support the ANSI-92 entry level SQL grammar?
! * All JDBC Compliant drivers must return true. We currently
! * report false until 'schema' support is added. Then this
! * should be changed to return true, since we will be mostly
! * compliant (probably more compliant than many other databases)
! * And since this is a requirement for all JDBC drivers we
! * need to get to the point where we can return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 726,732 ****
}

/**
!    * Is some form of outer join supported?  From my knowledge, nope.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 731,737 ----
}

/**
! * Is some form of outer join supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 737,744 ****
}

/**
!    * Are full nexted outer joins supported?  Well, we dont support any
!    * form of outer join, so this is no as well
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 742,748 ----
}

/**
! * Are full nexted outer joins supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 749,756 ****
}

/**
!    * Is there limited support for outer joins?  (This will be true if
!    * supportFullOuterJoins is true)
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 753,759 ----
}

/**
! * Is there limited support for outer joins?
*
* @return true if so
* @exception SQLException if a database access error occurs

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Bruce Momjian
bruce@momjian.us
In reply to: Barry Lind (#1)
Re: Patch for JDBC to update some comments

Thanks. Patch applied.

This patch updates some comments in the DatabaseMetaData classes to
reflect a mail thread that discussed our conformance (or lack thereof)
to the SQL92 spec.

thanks,
--Barry

*** ./interfaces/jdbc/org/postgresql/jdbc1/DatabaseMetaData.java.orig	Sat Aug  4 12:32:04 2001
--- ./interfaces/jdbc/org/postgresql/jdbc1/DatabaseMetaData.java	Wed Aug 15 22:39:55 2001
***************
*** 680,686 ****
/**
* Does this driver support the ANSI-92 entry level SQL grammar?
!    * All JDBC Compliant drivers must return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 680,691 ----

/**
* Does this driver support the ANSI-92 entry level SQL grammar?
! * All JDBC Compliant drivers must return true. We currently
! * report false until 'schema' support is added. Then this
! * should be changed to return true, since we will be mostly
! * compliant (probably more compliant than many other databases)
! * And since this is a requirement for all JDBC drivers we
! * need to get to the point where we can return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 726,732 ****
}

/**
!    * Is some form of outer join supported?  From my knowledge, nope.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 731,737 ----
}

/**
! * Is some form of outer join supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 737,744 ****
}

/**
!    * Are full nexted outer joins supported?  Well, we dont support any
!    * form of outer join, so this is no as well
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 742,748 ----
}

/**
! * Are full nexted outer joins supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 749,756 ****
}

/**
!    * Is there limited support for outer joins?  (This will be true if
!    * supportFullOuterJoins is true)
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 753,759 ----
}
/**
!    * Is there limited support for outer joins?
*
* @return true if so
* @exception SQLException if a database access error occurs
*** ./interfaces/jdbc/org/postgresql/jdbc2/DatabaseMetaData.java.orig	Wed Aug 15 22:25:44 2001
--- ./interfaces/jdbc/org/postgresql/jdbc2/DatabaseMetaData.java	Wed Aug 15 22:37:10 2001
***************
*** 680,686 ****
/**
* Does this driver support the ANSI-92 entry level SQL grammar?
!    * All JDBC Compliant drivers must return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 680,691 ----

/**
* Does this driver support the ANSI-92 entry level SQL grammar?
! * All JDBC Compliant drivers must return true. We currently
! * report false until 'schema' support is added. Then this
! * should be changed to return true, since we will be mostly
! * compliant (probably more compliant than many other databases)
! * And since this is a requirement for all JDBC drivers we
! * need to get to the point where we can return true.
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 726,732 ****
}

/**
!    * Is some form of outer join supported?  From my knowledge, nope.
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 731,737 ----
}

/**
! * Is some form of outer join supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 737,744 ****
}

/**
!    * Are full nexted outer joins supported?  Well, we dont support any
!    * form of outer join, so this is no as well
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 742,748 ----
}

/**
! * Are full nexted outer joins supported?
*
* @return true if so
* @exception SQLException if a database access error occurs
***************
*** 749,756 ****
}

/**
!    * Is there limited support for outer joins?  (This will be true if
!    * supportFullOuterJoins is true)
*
* @return true if so
* @exception SQLException if a database access error occurs
--- 753,759 ----
}

/**
! * Is there limited support for outer joins?
*
* @return true if so
* @exception SQLException if a database access error occurs

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026