official submission for OU8/UnixWare sharedlib patch

Started by Larry Rosenmanalmost 25 years ago6 messagespatches

Jump to latest

Larry Rosenman

ler@lerctr.org

almost 25 years ago

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...

Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
  else
  CXXFLAGS_SL = -K PIC
  endif

  %.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
  else
  CXXFLAGS_SL = -K PIC
  endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif

%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Larry Rosenman

ler@lerctr.org

almost 25 years ago

In reply to: Larry Rosenman (#1)

Re: official submission for OU8/UnixWare sharedlib patch

* Peter Eisentraut <peter_e@gmx.net> [010827 09:08]:

Larry Rosenman writes:

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

The -Bdynamic probably ought to disappear.

that was there already, but I have no objections. I was trying to
make minimal changes.

LER

This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...
Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
else
CXXFLAGS_SL = -K PIC
endif
%.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
else
CXXFLAGS_SL = -K PIC
endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif
%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<
--
Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Import Notes

Reply to msg id not found: Pine.LNX.4.30.0108271611290.679-100000@peter.localdomain

Peter Eisentraut

peter_e@gmx.net

almost 25 years ago

In reply to: Larry Rosenman (#1)

Re: official submission for OU8/UnixWare sharedlib patch

Larry Rosenman writes:

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

The -Bdynamic probably ought to disappear.

This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...

Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
else
CXXFLAGS_SL = -K PIC
endif

%.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
else
CXXFLAGS_SL = -K PIC
endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif

%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<

--
Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter

Bruce Momjian

bruce@momjian.us

almost 25 years ago

In reply to: Larry Rosenman (#1)

Re: official submission for OU8/UnixWare sharedlib patch

Removal of -Bdynamic too.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...
Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
else
CXXFLAGS_SL = -K PIC
endif
%.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
else
CXXFLAGS_SL = -K PIC
endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif
%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian

bruce@momjian.us

almost 25 years ago

In reply to: Larry Rosenman (#1)

Re: official submission for OU8/UnixWare sharedlib patch

Patch applied. Thanks.

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...
Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
else
CXXFLAGS_SL = -K PIC
endif
%.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
else
CXXFLAGS_SL = -K PIC
endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif
%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian

bruce@momjian.us

almost 25 years ago

In reply to: Larry Rosenman (#2)

Re: official submission for OU8/UnixWare sharedlib patch

-Bdynamic removed as requested.

* Peter Eisentraut <peter_e@gmx.net> [010827 09:08]:

Larry Rosenman writes:

I sent this to -hackers and peter_e, but thought it ought to go to
-patches as well.

The -Bdynamic probably ought to disappear.

that was there already, but I have no objections. I was trying to
make minimal changes.

LER
This fixes the regression test .so builds on sysv5 systems:
I believe this will fix peter_e's problen with gcc.

Please advise if this is a bad idea...
Index: Makefile.unixware
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/makefiles/Makefile.unixware,v
retrieving revision 1.9
diff -c -r1.9 Makefile.unixware
*** Makefile.unixware	2000/12/16 18:14:25	1.9
--- Makefile.unixware	2001/08/25 18:22:36
***************
*** 16,21 ****
else
CXXFLAGS_SL = -K PIC
endif
%.so: %.o
! 	$(LD) -G -Bdynamic -o $@ $<
--- 16,26 ----
else
CXXFLAGS_SL = -K PIC
endif
+ ifeq ($(GCC), yes)
+ SO_FLAGS = -shared
+ else
+ SO_FLAGS = -G
+ endif
%.so: %.o
! $(CC) $(SO_FLAGS) -Bdynamic -o $@ $<
--
Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026