[PATCH] Patch for more verbose error reporting in pl/tcl

Started by Vsevolod Lobkoalmost 25 years ago8 messagespatches
Jump to latest
#1Vsevolod Lobko
seva@sevasoft.kiev.ua

This patch adds reporting of tcl global variable errorInfo
which contains stack trace.
One problem, after this patch errors will generate multiline ERROR
messages. Is it acceptable or do I need split it and generate multiple
singleline messages?

Attachments:

pgdifftext/plain; charset=US-ASCII; name=pgdiffDownload+4-2
#2Vsevolod Lobko
seva@sevasoft.kiev.ua
In reply to: Vsevolod Lobko (#1)
Re: [PATCH] Patch for more verbose error reporting in

Previous patch has problems with 8-bit characters :))
Attached corrected version.

On Wed, 3 Oct 2001, Vsevolod Lobko wrote:

This patch adds reporting of tcl global variable errorInfo
which contains stack trace.
One problem, after this patch errors will generate multiline ERROR
messages. Is it acceptable or do I need split it and generate multiple
singleline messages?

Multiline messages was used in pltcl.c already, so I think this is
acceptable.

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Vsevolod Lobko (#2)
Re: [PATCH] Patch for more verbose error reporting in

Vsevolod Lobko <seva@sevasoft.kiev.ua> writes:

Previous patch has problems with 8-bit characters :))
Attached corrected version.

Um, no sign of the attachment?

One problem, after this patch errors will generate multiline ERROR
messages. Is it acceptable or do I need split it and generate multiple
singleline messages?

No, that's okay.

regards, tom lane

#4Bruce Momjian
bruce@momjian.us
In reply to: Vsevolod Lobko (#1)
Re: [PATCH] Patch for more verbose error reporting in pl/tcl

Multi-line error messages are fine.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

This patch adds reporting of tcl global variable errorInfo
which contains stack trace.
One problem, after this patch errors will generate multiline ERROR
messages. Is it acceptable or do I need split it and generate multiple
singleline messages?

Content-Description:

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#5Vsevolod Lobko
seva@sevasoft.kiev.ua
In reply to: Tom Lane (#3)
Re: [PATCH] Patch for more verbose error reporting in

On Wed, 3 Oct 2001, Tom Lane wrote:

Vsevolod Lobko <seva@sevasoft.kiev.ua> writes:

Previous patch has problems with 8-bit characters :))
Attached corrected version.

Um, no sign of the attachment?

Now really attached

Attachments:

pgdifftext/plain; charset=US-ASCII; name=pgdiffDownload+10-2
#6Bruce Momjian
bruce@momjian.us
In reply to: Vsevolod Lobko (#5)
Re: [PATCH] Patch for more verbose error reporting in

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

On Wed, 3 Oct 2001, Tom Lane wrote:

Vsevolod Lobko <seva@sevasoft.kiev.ua> writes:

Previous patch has problems with 8-bit characters :))
Attached corrected version.

Um, no sign of the attachment?

Now really attached

Content-Description:

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7Bruce Momjian
bruce@momjian.us
In reply to: Vsevolod Lobko (#1)
Re: [PATCH] Patch for more verbose error reporting in pl/tcl

Newer version applied. Thanks.

This patch adds reporting of tcl global variable errorInfo
which contains stack trace.
One problem, after this patch errors will generate multiline ERROR
messages. Is it acceptable or do I need split it and generate multiple
singleline messages?

Content-Description:

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#8Bruce Momjian
bruce@momjian.us
In reply to: Vsevolod Lobko (#5)
Re: [PATCH] Patch for more verbose error reporting in

This is the one I applied.

On Wed, 3 Oct 2001, Tom Lane wrote:

Vsevolod Lobko <seva@sevasoft.kiev.ua> writes:

Previous patch has problems with 8-bit characters :))
Attached corrected version.

Um, no sign of the attachment?

Now really attached

Content-Description:

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026