Add regression test for ALTER TABLE / ADD UNIQUE
OK,
I've attached a patch that adds some regression tests for alter table / add
unique.
One thing that I don't understand tho, is why when adding a unique
constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my
code it has ALTER TABLE/ADD UNIQUE - I don't understand...
I've only had the chance to test this test suite on my own machine, so you
may wish to test it elsewhere before committing it.
It includes tests for multi-column indices and indices over oid columns.
Chris
Attachments:
regress.difftext/x-diff; charset=iso-8859-1; name=regress.diffDownload+112-0
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
OK,
I've attached a patch that adds some regression tests for alter table / add
unique.One thing that I don't understand tho, is why when adding a unique
constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my
code it has ALTER TABLE/ADD UNIQUE - I don't understand...I've only had the chance to test this test suite on my own machine, so you
may wish to test it elsewhere before committing it.It includes tests for multi-column indices and indices over oid columns.
Chris
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026OK,
I've attached a patch that adds some regression tests for alter table / add
unique.One thing that I don't understand tho, is why when adding a unique
constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my
code it has ALTER TABLE/ADD UNIQUE - I don't understand...
The cause is that the message is coming from parser/analyze.c rather
than commands/command.c. You are right to be concerned about the
consistent wording and spacing because there are multiple words on each
side of the slash so you really need the spaces for added visibility:
ALTER TABLE / ADD UNIQUE
I've only had the chance to test this test suite on my own machine, so you
may wish to test it elsewhere before committing it.It includes tests for multi-column indices and indices over oid columns.
I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.
The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.
I will hold your patch and mine in the queue to see if people have
comments on this and apply accordingly.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Attachments:
/bjm/difftext/plainDownload+96-96
----- Original Message -----
From: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)
I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.
Bruce, you've gone only half way through adding spaces.
Attached patch fixes few more of those.
The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.
Updated version of backend/po/ru.po coming shortly with few more translated
messages.
--
Serguei A. Mokhov
Attachments:
Import Notes
Resolved by subject fallback
I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.
You might want to change the 'PRIMARY KEY' bit to 'ADD PRIMARY KEY' also,
but then again I haven't written that code yet!
The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.I will hold your patch and mine in the queue to see if people have
comments on this and apply accordingly.
Cool.
Chris
----- Original Message -----
From: Serguei Mokhov <sa_mokho@alcor.concordia.ca>
Sent: Monday, October 29, 2001 6:09 PM
----- Original Message -----
From: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.Bruce, you've gone only half way through adding spaces.
Attached patch fixes few more of those.
I just realized... Please, don't apply this patch without
appropriate changes to the expected results of the regression tests!
-s
----- Original Message -----
From: Serguei Mokhov <sa_mokho@alcor.concordia.ca>
Sent: Monday, October 29, 2001 6:09 PM----- Original Message -----
From: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.Bruce, you've gone only half way through adding spaces.
Attached patch fixes few more of those.I just realized... Please, don't apply this patch without
appropriate changes to the expected results of the regression tests!
Yes, of course. I will check regression output before committing.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
----- Original Message -----
From: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.Bruce, you've gone only half way through adding spaces.
Attached patch fixes few more of those.The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.Updated version of backend/po/ru.po coming shortly with few more translated
messages.--
Serguei A. Mokhov
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Patch applied.
---------------------------------------------------------------------------
OK,
I've attached a patch that adds some regression tests for alter table / add
unique.One thing that I don't understand tho, is why when adding a unique
constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my
code it has ALTER TABLE/ADD UNIQUE - I don't understand...I've only had the chance to test this test suite on my own machine, so you
may wish to test it elsewhere before committing it.It includes tests for multi-column indices and indices over oid columns.
Chris
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Patch applied.
---------------------------------------------------------------------------
OK,
I've attached a patch that adds some regression tests for alter table / add
unique.One thing that I don't understand tho, is why when adding a unique
constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my
code it has ALTER TABLE/ADD UNIQUE - I don't understand...The cause is that the message is coming from parser/analyze.c rather
than commands/command.c. You are right to be concerned about the
consistent wording and spacing because there are multiple words on each
side of the slash so you really need the spaces for added visibility:ALTER TABLE / ADD UNIQUE
I've only had the chance to test this test suite on my own machine, so you
may wish to test it elsewhere before committing it.It includes tests for multi-column indices and indices over oid columns.
I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.I will hold your patch and mine in the queue to see if people have
comments on this and apply accordingly.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Import Notes
Reply to msg id not found: fromenvpgmanatOct292001013144pm | Resolved by subject fallback
Patch applied. Thanks.
---------------------------------------------------------------------------
----- Original Message -----
From: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.Bruce, you've gone only half way through adding spaces.
Attached patch fixes few more of those.The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.Updated version of backend/po/ru.po coming shortly with few more translated
messages.--
Serguei A. Mokhov
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026I would like to apply the following patch to make your patch show ADD
UNIQUE instead of just UNIQUE and add spacing around the slash in a few
cases that were inconsistent.You might want to change the 'PRIMARY KEY' bit to 'ADD PRIMARY KEY' also,
but then again I haven't written that code yet!The only question I have is how to handle backend/po files. I can
easily add the spaces to match the new format if that is OK with the po
maintainers.I will hold your patch and mine in the queue to see if people have
comments on this and apply accordingly.Cool.
"ADD" added and regression expected output modified to match.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026