fix for bison warnings
Bison 1.34 is more picky about requiring rules to be terminated with
semi-colons. As a result, current sources generate a number of warnings.
This patch fixes that.
I'm no yacc expert, but this is pretty straight forward, so hopefully I
haven't buggered anything ;-) It passes the regression tests.
Cheers,
Neil
--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC
Attachments:
bison-fixes.patchtext/plain; charset=ISO-8859-1Download+26-3
I recently fixed several such problems in ecpg and will apply any
remaining ones from this patch.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
Bison 1.34 is more picky about requiring rules to be terminated with
semi-colons. As a result, current sources generate a number of warnings.
This patch fixes that.I'm no yacc expert, but this is pretty straight forward, so hopefully I
haven't buggered anything ;-) It passes the regression tests.Cheers,
Neil
--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian <pgman@candle.pha.pa.us> writes:
I recently fixed several such problems in ecpg and will apply any
remaining ones from this patch.
I will apply the main-grammar parts of this, as it overlaps with some
changes I'm about to commit. (I'd noticed one or two of the missing
semis myself while making schema-related edits, but it's good to have
a tool that finds them all...)
I'm not planning to touch ecpg's grammar however, as my luck with
updating ecpg has been very bad --- Meskes keeps overwriting my
changes :-(.
regards, tom lane
Tom Lane wrote:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
I recently fixed several such problems in ecpg and will apply any
remaining ones from this patch.I will apply the main-grammar parts of this, as it overlaps with some
changes I'm about to commit. (I'd noticed one or two of the missing
semis myself while making schema-related edits, but it's good to have
a tool that finds them all...)
Fine. Yes, I was surprised it didn't fail without the semicolons.
I'm not planning to touch ecpg's grammar however, as my luck with
updating ecpg has been very bad --- Meskes keeps overwriting my
changes :-(.
My guess is that I already fixed all the ecpg ones as part of my
reformatting but I will make sure and apply any ecpg parts I missed.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Applied ecpg section. Tom is applying the rest.
---------------------------------------------------------------------------
Neil Conway wrote:
Bison 1.34 is more picky about requiring rules to be terminated with
semi-colons. As a result, current sources generate a number of warnings.
This patch fixes that.I'm no yacc expert, but this is pretty straight forward, so hopefully I
haven't buggered anything ;-) It passes the regression tests.Cheers,
Neil
--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026