earthdistance fixes, but no cube stuff

Started by Bruno Wolff IIIalmost 24 years ago6 messagespatches
Jump to latest
#1Bruno Wolff III
bruno@wolff.to

I have included fixes to declare some floating point constants as double
instead of int, change the calculation method to use the haversine formula
which is more accurrate for short distances, added a grant to public for
geo_distance and added a regression test.

I will resubmit the earth distance stuff based on cube after 7.3 is released.

Attachments:

earth.difftext/plain; charset=us-asciiDownload+248-33
#2Bruce Momjian
bruce@momjian.us
In reply to: Bruno Wolff III (#1)
Re: earthdistance fixes, but no cube stuff

Bruno, I have two patches from you; one is larger and I think you
submitted this one because we were in feature freeze. However, I don't
think we do feature freeze for /contrib, do we? Which one should we
apply folks?

---------------------------------------------------------------------------

Bruno Wolff III wrote:

I have included fixes to declare some floating point constants as double
instead of int, change the calculation method to use the haversine formula
which is more accurrate for short distances, added a grant to public for
geo_distance and added a regression test.

I will resubmit the earth distance stuff based on cube after 7.3 is released.

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: earthdistance fixes, but no cube stuff

Bruce Momjian <pgman@candle.pha.pa.us> writes:

However, I don't
think we do feature freeze for /contrib, do we?

While our standards are laxer for contrib, I don't think they are so
lax as to accept a major feature upgrade that includes a whole bunch
of unresolved build/install procedural problems. I vote "hold for 7.4"
on the larger patch. The bug-fix-only patch seems reasonable though.

regards, tom lane

#4Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#3)
Re: earthdistance fixes, but no cube stuff

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

However, I don't
think we do feature freeze for /contrib, do we?

While our standards are laxer for contrib, I don't think they are so
lax as to accept a major feature upgrade that includes a whole bunch
of unresolved build/install procedural problems. I vote "hold for 7.4"
on the larger patch. The bug-fix-only patch seems reasonable though.

Oh, yea, it clearly has to build. I'll put the smaller patch in the
queue and save the bigger one for review in 7.4.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#5Bruce Momjian
bruce@momjian.us
In reply to: Bruno Wolff III (#1)
Re: earthdistance fixes, but no cube stuff

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Bruno Wolff III wrote:

I have included fixes to declare some floating point constants as double
instead of int, change the calculation method to use the haversine formula
which is more accurrate for short distances, added a grant to public for
geo_distance and added a regression test.

I will resubmit the earth distance stuff based on cube after 7.3 is released.

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#6Bruce Momjian
bruce@momjian.us
In reply to: Bruno Wolff III (#1)
Re: earthdistance fixes, but no cube stuff

Patch applied. Thanks.

---------------------------------------------------------------------------

Bruno Wolff III wrote:

I have included fixes to declare some floating point constants as double
instead of int, change the calculation method to use the haversine formula
which is more accurrate for short distances, added a grant to public for
geo_distance and added a regression test.

I will resubmit the earth distance stuff based on cube after 7.3 is released.

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073