SEQUENCEs and NO MAXVALUE NO MINVALUE

Rod Taylor <rbt@rbt.ca> writes:

Adds in NO MAXVALUE and NO MINVALUE options for create sequence per 200X
spec, which will also make alter sequence a touch easier.

What are these supposed to do exactly? There is no such animal as a
sequence that hasn't got a maxvalue, nor one without a minvalue.
"Large" does not mean "unlimited".

I'm not eager to pick up evidently-poorly-thought-out features from a
draft spec that is nowhere near being frozen. Anyway, didn't we decide
that converging syntax with 200X was a bad idea if we weren't going to
converge semantics?

regards, tom lane

On Wed, 2003-01-22 at 20:37, Tom Lane wrote:

Rod Taylor <rbt@rbt.ca> writes:

Adds in NO MAXVALUE and NO MINVALUE options for create sequence per 200X
spec, which will also make alter sequence a touch easier.

What are these supposed to do exactly? There is no such animal as a
sequence that hasn't got a maxvalue, nor one without a minvalue.
"Large" does not mean "unlimited".

6) Case:
a) If <sequence generator maxvalue option> is specified, then Case:
i) If NO MAXVALUE is specified, then let SMAX be an
implementation-defined <signed numeric literal> of declared type DT.
ii) Otherwise, let SMAX be <sequence generator max value>.
b) Otherwise, let SMAX be an implementation-defined <signed numeric
literal> of declared type DT.

7) Case:
a) If <sequence generator minvalue option> is specified, then Case:
i) If NO MINVALUE is specified, then let SMIN be an
implementation-defined <signed numeric literal> of declared type DT.
ii) Otherwise, let SMIN be <sequence generator min value>.
b) Otherwise, let SMIN be an implementation-defined <signed numeric
literal> of declared type DT.

I'm not eager to pick up evidently-poorly-thought-out features from a
draft spec that is nowhere near being frozen.

These 2 particular items are to spec, with the exception that we don't
stop at the limit of the datatype, int4's have int8 limits.

I think we need an ALTER SEQUENCE command, especially once dependencies
are fully tracked on them. This will include some method of returning
to the defaults.

Anyway, didn't we decide that converging syntax with 200X was a
bad idea if we weren't going to converge semantics?

Too late for that. The rest of the create sequence syntax is in-line
with the new spec, with the exception of the above 2 items.

--
Rod Taylor <rbt@rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

Tom Lane writes:

I'm not eager to pick up evidently-poorly-thought-out features from a
draft spec that is nowhere near being frozen. Anyway, didn't we decide
that converging syntax with 200X was a bad idea if we weren't going to
converge semantics?

I think we realized that the semantics are the same.

--
Peter Eisentraut peter_e@gmx.net

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Tom Lane wrote:

Rod Taylor <rbt@rbt.ca> writes:

Adds in NO MAXVALUE and NO MINVALUE options for create sequence per 200X
spec, which will also make alter sequence a touch easier.

What are these supposed to do exactly? There is no such animal as a
sequence that hasn't got a maxvalue, nor one without a minvalue.
"Large" does not mean "unlimited".

I'm not eager to pick up evidently-poorly-thought-out features from a
draft spec that is nowhere near being frozen. Anyway, didn't we decide
that converging syntax with 200X was a bad idea if we weren't going to
converge semantics?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.

Adds in NO MAXVALUE and NO MINVALUE options for create sequence per 200X
spec, which will also make alter sequence a touch easier.

sequence.c init_params() will check for settings which have been
defined twice, and complain.

--
Rod Taylor <rbt@rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Patch applied. Thanks.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.

Adds in NO MAXVALUE and NO MINVALUE options for create sequence per 200X
spec, which will also make alter sequence a touch easier.

sequence.c init_params() will check for settings which have been
defined twice, and complain.

--
Rod Taylor <rbt@rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073