Sequence patch has problems

Started by Tom Laneover 23 years ago2 messagespatches
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

I assume these are from the recently-applied sequence patch:

sequence.c: In function `DefineSequence':
sequence.c:99: warning: assignment makes integer from pointer without a cast
sequence.c:100: warning: assignment makes integer from pointer without a cast
sequence.c:101: warning: assignment makes integer from pointer without a cast
sequence.c:102: warning: assignment makes integer from pointer without a cast
sequence.c:103: warning: assignment makes integer from pointer without a cast
sequence.c: In function `init_params':
sequence.c:882: warning: comparison between pointer and integer
sequence.c:883: warning: comparison between pointer and integer
sequence.c:920: warning: comparison between pointer and integer
sequence.c:931: warning: comparison between pointer and integer
sequence.c:943: warning: comparison between pointer and integer
sequence.c:966: warning: comparison between pointer and integer

regards, tom lane

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: Sequence patch has problems

Here is the fix, applied. It was assigning NULL to an int32. Strange
my compiler didn't complain.

---------------------------------------------------------------------------

Tom Lane wrote:

I assume these are from the recently-applied sequence patch:

sequence.c: In function `DefineSequence':
sequence.c:99: warning: assignment makes integer from pointer without a cast
sequence.c:100: warning: assignment makes integer from pointer without a cast
sequence.c:101: warning: assignment makes integer from pointer without a cast
sequence.c:102: warning: assignment makes integer from pointer without a cast
sequence.c:103: warning: assignment makes integer from pointer without a cast
sequence.c: In function `init_params':
sequence.c:882: warning: comparison between pointer and integer
sequence.c:883: warning: comparison between pointer and integer
sequence.c:920: warning: comparison between pointer and integer
sequence.c:931: warning: comparison between pointer and integer
sequence.c:943: warning: comparison between pointer and integer
sequence.c:966: warning: comparison between pointer and integer

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Attachments:

/bjm/difftext/plainDownload+22-22