log_min_duration_statement #2

Started by Christopher Kings-Lynneover 23 years ago7 messagespatches
Jump to latest
#1Christopher Kings-Lynne
chriskl@familyhealth.com.au

OK,

This limits max value to INT_MAX / 1000.

Chris

Attachments:

guc.txttext/plain; name=guc.txtDownload+70-36
#2Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Christopher Kings-Lynne (#1)
Re: log_min_duration_statement #2

Oh, whoever commits this - please add <literal></literal> around 2147483 in
the runtime.sgml patch...

Thanks,

Chris

----- Original Message -----
From: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
To: "Patches" <pgsql-patches@postgresql.org>
Sent: Wednesday, April 23, 2003 11:38 AM
Subject: [PATCHES] log_min_duration_statement #2

OK,

This limits max value to INT_MAX / 1000.

Chris

----------------------------------------------------------------------------
----

Show quoted text

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#3Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Christopher Kings-Lynne (#1)
Re: log_min_duration_statement #2

Is this going to be committed?

Chris

----- Original Message -----
From: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
To: "Patches" <pgsql-patches@postgresql.org>
Sent: Wednesday, April 23, 2003 11:38 AM
Subject: [PATCHES] log_min_duration_statement #2

OK,

This limits max value to INT_MAX / 1000.

Chris

----------------------------------------------------------------------------
----

Show quoted text

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#4Bruce Momjian
bruce@momjian.us
In reply to: Christopher Kings-Lynne (#3)
Re: log_min_duration_statement #2

Yes, sorry. I am getting behind with the Win32 work.

---------------------------------------------------------------------------

Christopher Kings-Lynne wrote:

Is this going to be committed?

Chris

----- Original Message -----
From: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
To: "Patches" <pgsql-patches@postgresql.org>
Sent: Wednesday, April 23, 2003 11:38 AM
Subject: [PATCHES] log_min_duration_statement #2

OK,

This limits max value to INT_MAX / 1000.

Chris

----------------------------------------------------------------------------
----

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#5Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Bruce Momjian (#4)
Re: log_min_duration_statement #2

That's OK - just wondering if anyone noticed it...

Chris

----- Original Message -----
From: "Bruce Momjian" <pgman@candle.pha.pa.us>
To: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
Cc: "Patches" <pgsql-patches@postgresql.org>
Sent: Wednesday, April 30, 2003 11:29 AM
Subject: Re: [PATCHES] log_min_duration_statement #2

Yes, sorry. I am getting behind with the Win32 work.

--------------------------------------------------------------------------

-

Christopher Kings-Lynne wrote:

Is this going to be committed?

Chris

----- Original Message -----
From: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
To: "Patches" <pgsql-patches@postgresql.org>
Sent: Wednesday, April 23, 2003 11:38 AM
Subject: [PATCHES] log_min_duration_statement #2

OK,

This limits max value to INT_MAX / 1000.

Chris

--------------------------------------------------------------------------

--

----

---------------------------(end of

broadcast)---------------------------

TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 359-1001
+  If your life is a hard drive,     |  13 Roberts Road
+  Christ can be your backup.        |  Newtown Square, Pennsylvania

19073

Show quoted text

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

#6Bruce Momjian
bruce@momjian.us
In reply to: Christopher Kings-Lynne (#1)
Re: log_min_duration_statement #2

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I am going to modify your patch slightly. I am going to configure it so
if you set the value to '1', you always get the duration and statement.
As it is coded, a query less than 1 millisecond will not print with a
value of '1', and I am going to document this behavior. I am also going
to remove the mention of the maximum in the docs --- seems unnecessary.

---------------------------------------------------------------------------

Christopher Kings-Lynne wrote:

OK,

This limits max value to INT_MAX / 1000.

Chris

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#7Bruce Momjian
bruce@momjian.us
In reply to: Christopher Kings-Lynne (#1)
Re: log_min_duration_statement #2

OK, patch applied. I adjusted the documentation to not mention the
maximum (seemed unnecessary). I also adjusted the output to be clearer
by placing the duration at the start, with no 'sec' legend:

LOG: duration_statement: 0.020185 select * from pg_language, pg_class;

---------------------------------------------------------------------------

Christopher Kings-Lynne wrote:

OK,

This limits max value to INT_MAX / 1000.

Chris

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Attachments:

/bjm/difftext/plainDownload+68-35