Waiting the patch applied

Started by Gaetano Mendolaalmost 23 years ago4 messagespatches
Jump to latest
#1Gaetano Mendola
mendola@bigfoot.com

Hi,
one question just to know the right action to take:
After having submitted a patch in order to work on a
new patch shall I open another fresh CVS snapshot or shall
I work on top of my old patch not yet applied ( or refused )?

Regards
Gaetano Mendola

#2Bruce Momjian
bruce@momjian.us
In reply to: Gaetano Mendola (#1)
Re: Waiting the patch applied

Gaetano Mendola wrote:

Hi,
one question just to know the right action to take:
After having submitted a patch in order to work on a
new patch shall I open another fresh CVS snapshot or shall
I work on top of my old patch not yet applied ( or refused )?

Whichever is easier for you.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Peter Eisentraut
peter_e@gmx.net
In reply to: Gaetano Mendola (#1)
Re: Waiting the patch applied

Gaetano Mendola writes:

one question just to know the right action to take:
After having submitted a patch in order to work on a
new patch shall I open another fresh CVS snapshot or shall
I work on top of my old patch not yet applied ( or refused )?

Since applying the patch will change the CVS header in the affected files,
this will mess up your next diff. Details depend on how you work exactly,
but I remember having been burned by this exact issue several times. If
your new work depends on your old patch being applied, then you'll just
have to keep an extended set of working and reference trees around.

--
Peter Eisentraut peter_e@gmx.net

#4Gaetano Mendola
mendola@bigfoot.com
In reply to: Peter Eisentraut (#3)
Re: Waiting the patch applied

Peter Eisentraut wrote:

Gaetano Mendola writes:

one question just to know the right action to take:
After having submitted a patch in order to work on a
new patch shall I open another fresh CVS snapshot or shall
I work on top of my old patch not yet applied ( or refused )?

Since applying the patch will change the CVS header in the affected files,
this will mess up your next diff. Details depend on how you work exactly,
but I remember having been burned by this exact issue several times. If
your new work depends on your old patch being applied, then you'll just
have to keep an extended set of working and reference trees around.

Ok, I will take a fresh sandbox then.

Thank you
Gaetano Mendola