Re: patches for WIN32_CONSOLE problem

Patch applied. Thanks.

Yes, I removed the doc mentions of WIN32_CONSOLE already.

---------------------------------------------------------------------------

Christoph Dalitz wrote:

On Thu, 11 Sep 2003 12:45:22 -0400 (EDT)
Bruce Momjian <pgman@candle.pha.pa.us> wrote:

a) Write documentation how the win32 console needs to be set up so that
psql can handle 8-bit characters.
Where should it be added? The Section "Installation on Windows" in the
Administrator's Guide seems natural to me.

b) Add code to psql that prints a warning on startup of psql when the
console codepage differs from the windows codepage, something like

Warning: Console codepage (850) differs from windows codepage (1252)
8-bit characters will not work correctly. See PostgreSQL
documentation "Installation on Windows" for details.

Attached are two patches:

- installdoc.patch contains an additional paragraph on the win32 console
codepage for the chapter "Installation on Windows"
Due to a lack of SGML-tools, I have only edited the text and not tested
the SGML code - please check it before merging into the CVS branch.

- psqlcodepage.patch adds the warning about a problematic codepage to psql.

Could you please already remove the WIN32_CONSOLE and OemToChar/CharToOem stuff
from psql? Sorry for the inconvenience generated by my ignorance.

Did you remove it also from the psql doc?

Thanks,

Christoph

[ Attachment, skipping... ]

[ Attachment, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073