Minor fixes (mostly win32)

Started by Claudio Natoliover 22 years ago3 messagespatches
Jump to latest
#1Claudio Natoli
claudio.natoli@memetrics.com

For application to HEAD, following community review.

* Mostly, casting etc to remove compilation warnings in win32 only code.

* main.c: set _IONBF to stdout/stderr under win32 (under win32, _IOLBF
defaults to full buffering)

* pg_resetxlog/Makefile: ensures dirmod.o gets cleaned (got bitten by this
when, after "make clean"ing, switching compilation between Ming + Cygwin)

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Attachments:

minor-win32.outapplication/octet-stream; name=minor-win32.outDownload+43-37
#2Magnus Hagander
magnus@hagander.net
In reply to: Claudio Natoli (#1)
Re: Minor fixes (mostly win32)

For application to HEAD, following community review.

* Mostly, casting etc to remove compilation warnings in win32
only code.

* main.c: set _IONBF to stdout/stderr under win32 (under
win32, _IOLBF defaults to full buffering)

* pg_resetxlog/Makefile: ensures dirmod.o gets cleaned (got
bitten by this when, after "make clean"ing, switching
compilation between Ming + Cygwin)

FWIW, looks good to me.

These buffering fixes - are they enough to get around the buffering
issues on the mingw console? I assume no?

//Magnus

#3Claudio Natoli
claudio.natoli@memetrics.com
In reply to: Magnus Hagander (#2)
Re: Minor fixes (mostly win32)

These buffering fixes - are they enough to get around the buffering
issues on the mingw console? I assume no?

Nope. :-( That's one for the mingw/msys people.

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>