enable jade warnings

Started by Neil Conwayover 22 years ago3 messagespatches
Jump to latest
#1Neil Conway
neilc@samurai.com

Attached is a crude patch to enable some additional jade/openjade
warnings. This should help us catch improper or ill-advised SGML in
the docs.

I disabled the warning for empty tags, as they are used throughout the
SGML docs and there is no point in getting rid of them. I also
disabled the warning for unused parameter types, as that triggers a
warning in a system DTD on my machine.

Unless anyone objects, I'll apply this within 24 hours.

-Neil

Attachments:

jade-warnings-1.patchtext/x-patch; name=jade-warnings-1.patchDownload+4-2
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Neil Conway (#1)
Re: enable jade warnings

Neil Conway wrote:

Attached is a crude patch to enable some additional jade/openjade
warnings. This should help us catch improper or ill-advised SGML in
the docs.

If that doesn't create any new warnings on the current (fixed) code,
then I agree with this. However, I'd like to see it factored more to
avoid repeating it for jade and nsgmls. The warning flags are in fact
SP flags, not Jade flags; only Jade is built on top of SP. So maybe
assign this to SPFLAGS and add that to both invocations. (This is a
bit analogous to CPPFLAGS vs. CFLAGS.)

#3Neil Conway
neilc@samurai.com
In reply to: Peter Eisentraut (#2)
Re: enable jade warnings

Peter Eisentraut wrote:

If that doesn't create any new warnings on the current (fixed) code,
then I agree with this.

(Right, it does not.)

However, I'd like to see it factored more to
avoid repeating it for jade and nsgmls. The warning flags are in fact
SP flags, not Jade flags; only Jade is built on top of SP. So maybe
assign this to SPFLAGS and add that to both invocations. (This is a
bit analogous to CPPFLAGS vs. CFLAGS.)

Attached is a patch that does this.

-Neil

Attachments:

jade-warnings-2.patchtext/x-patch; name=jade-warnings-2.patchDownload+6-4