Initial Review of Copy Command Patch

Started by mike gover 22 years ago2 messagespatches
Jump to latest
#1mike g
mike@thegodshalls.com

Hello,

I thought I would try and knock off the "count number of rows inserted
when using the Copy command" from the todo list.

The attached diff works for me on non-binary files using latest cvs

It seems though that I am making a redundant elog(INFO) call though.

If I run gmake check the Copy command does fail though....

Any comments or suggestions would be appreciated. I was going to post
this on the Hackers list but I am still waiting to reply to the initial
confirmation email(over an hour ago). I received the patch list
confirmation instantly.

Attachments:

copy.patchtext/x-patch; charset=; name=copy.patchDownload+24-0
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: mike g (#1)
Re: Initial Review of Copy Command Patch

mike g <mike@thegodshalls.com> writes:

I thought I would try and knock off the "count number of rows inserted
when using the Copy command" from the todo list.

I think what was envisioned was adding a field to the COPY command tag
returned at command completion. Sending an INFO message seems way too
noisy...

regards, tom lane