xlog.c timezone name size

Started by Korea PostgreSQL Users' Groupover 22 years ago2 messagespatches
Jump to latest
#1Korea PostgreSQL Users' Group
pgsql-kr@postgresql.or.kr

On multibyte language locale environment of win32, size of %Z of localtime() function is bigger more then 12 bytes.

so, I suggest that change str_time() function in src/backend/access/transam/xlog.c (2765 line)

buf char array size must be at least 70 bytes (20 bytes = datetime, 50 bytes = tzname of depended local locale(?))

Current str_time() function do not return new line on korean language win32 environment.
It's same on CJK.

#2Bruce Momjian
bruce@momjian.us
In reply to: Korea PostgreSQL Users' Group (#1)
Re: xlog.c timezone name size

I have increased the str_time() static variable length to 128. Thanks.

---------------------------------------------------------------------------

Korea PostgreSQL Users' Group wrote:

On multibyte language locale environment of win32, size of %Z of localtime() function is bigger more then 12 bytes.

so, I suggest that change str_time() function in src/backend/access/transam/xlog.c (2765 line)

buf char array size must be at least 70 bytes (20 bytes = datetime, 50 bytes = tzname of depended local locale(?))

Current str_time() function do not return new line on korean language win32 environment.
It's same on CJK.
---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073