charset / postmaster doc improv

Started by Neil Conwayover 22 years ago3 messagespatches
Jump to latest
#1Neil Conway
neilc@samurai.com

I've applied the attached patch to CVS HEAD. It improves the
postmaster reference page, the locale / character set docs, adds some
more cross-references to the locale / character set docs, and makes a
few minor fixes elsewhere. Any suggestions for future improvement are
welcome.

-Neil

Attachments:

charset_doc_improv-7.patchtext/x-patch; name=charset_doc_improv-7.patchDownload+120-119
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#1)
Re: charset / postmaster doc improv

Neil Conway <neilc@samurai.com> writes:

I've applied the attached patch to CVS HEAD. It improves the
postmaster reference page, the locale / character set docs, adds some
more cross-references to the locale / character set docs, and makes a
few minor fixes elsewhere. Any suggestions for future improvement are
welcome.

Looks good ... one trivial quibble:

!         This option is equivalent to setting <literal>listen_addresses</> in
!         <filename>postgresql.conf</>.
--- 171,185 ----
!         Specifying this option is equivalent to setting the <xref
!         linkend="guc-listen-addresses">.

"... setting the listen_addresses" seems a bit too brief to me; in a
medium that doesn't mark up the crossref at all, it'd seem disconnected.
I'd have written at least "the <xref linkend="guc-listen-addresses">
configuration parameter".

Just MHO though, others might see it differently.

regards, tom lane

#3Neil Conway
neilc@samurai.com
In reply to: Tom Lane (#2)
Re: charset / postmaster doc improv

On 22-Mar-04, at 11:54 PM, Tom Lane wrote:

"... setting the listen_addresses" seems a bit too brief to me; in a
medium that doesn't mark up the crossref at all, it'd seem
disconnected.
I'd have written at least "the <xref linkend="guc-listen-addresses">
configuration parameter".

Indeed, that's a typo. Good catch -- thanks! I've committed a fix for
this to CVS.

Cheers,

Neil