More fixes for pg_dump

Started by Christopher Kings-Lynneabout 22 years ago4 messagespatches
Jump to latest
#1Christopher Kings-Lynne
chriskl@familyhealth.com.au

This patch does two things to pg_dump:

* Dumps comments on columns of composite types

* Instead of putting all the OWNER TO commands at the end, it dumps then
after each object. This is WAY more readable and nice. ACLs are still
at the end.

Chris

Attachments:

pg_dump5.txt.gzapplication/x-gzip; name=pg_dump5.txt.gzDownload
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christopher Kings-Lynne (#1)
Re: More fixes for pg_dump

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:

This patch does two things to pg_dump:

* Dumps comments on columns of composite types

* Instead of putting all the OWNER TO commands at the end, it dumps then
after each object. This is WAY more readable and nice. ACLs are still
at the end.

Applied. I notice though that the line numbers don't seem to match CVS
tip, which suggests that you've got some patches still unapplied? If
so, Bruce seems to have missed adding them to the patch queue.

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: More fixes for pg_dump

Tom Lane wrote:

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:

This patch does two things to pg_dump:

* Dumps comments on columns of composite types

* Instead of putting all the OWNER TO commands at the end, it dumps then
after each object. This is WAY more readable and nice. ACLs are still
at the end.

Applied. I notice though that the line numbers don't seem to match CVS
tip, which suggests that you've got some patches still unapplied? If
so, Bruce seems to have missed adding them to the patch queue.

I don't know of any.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#2)
Re: More fixes for pg_dump

Applied. I notice though that the line numbers don't seem to match CVS
tip, which suggests that you've got some patches still unapplied? If
so, Bruce seems to have missed adding them to the patch queue.

Hmmm, no... Not sure what happened there. The diff in the committers
email seemed fine however.

Chris