comments on type attributes broken in 9.1devel

Started by Peter Eisentrautabout 15 years ago2 messages
#1Peter Eisentraut
peter_e@gmx.net

The comment code refactoring c10575ff005c330d0475345621b7d381eb510c48
broke comments on composite type attributes:

COMMENT ON COLUMN foo.a is 'test';
ERROR: 42809: "foo" is a composite type
LOCATION: heap_openrv, heapam.c:1110

This is because as the code was moved from CommentAttribute() to
get_object_address_attribute(), the call to relation_openrv() became a
heap_openrv(), which causes the above error.

Please check it out.

#2Robert Haas
robertmhaas@gmail.com
In reply to: Peter Eisentraut (#1)
Re: comments on type attributes broken in 9.1devel

On Tue, Oct 19, 2010 at 1:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

The comment code refactoring c10575ff005c330d0475345621b7d381eb510c48
broke comments on composite type attributes:

COMMENT ON COLUMN foo.a is 'test';
ERROR:  42809: "foo" is a composite type
LOCATION:  heap_openrv, heapam.c:1110

This is because as the code was moved from CommentAttribute() to
get_object_address_attribute(), the call to relation_openrv() became a
heap_openrv(), which causes the above error.

Please check it out.

Thanks. I changed that and added a regression test.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company