Win32 bug fix

Started by Claudio Natolialmost 22 years ago5 messagespatches
Jump to latest
#1Claudio Natoli
claudio.natoli@memetrics.com

Could someone please eyeball the attached patch for errors and as a
correction for:
http://archives.postgresql.org/pgsql-bugs/2004-08/msg00307.php

Also, could someone (Maksim?) please reproduce the bug on their system, and
then confirm that the patch corrects (as I seem unable to reproduce the bug,
which in itself is a mystery I don't have time to solve :-)

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Attachments:

diff.patchapplication/octet-stream; name=diff.patchDownload+22-24
#2Maksim Likharev
MLikharev@micropat.com
In reply to: Claudio Natoli (#1)
Re: Win32 bug fix

I'll compile and test this in a morning.
Thanks.

Show quoted text

-----Original Message-----
From: Claudio Natoli [mailto:claudio.natoli@memetrics.com]
Sent: Wednesday, August 25, 2004 9:20 PM
To: 'pgsql-patches@postgresql.org'
Cc: 'MLikharev@micropat.com'
Subject: Win32 bug fix

Could someone please eyeball the attached patch for errors and as a
correction for:
http://archives.postgresql.org/pgsql-bugs/2004-08/msg00307.php

Also, could someone (Maksim?) please reproduce the bug on
their system, and
then confirm that the patch corrects (as I seem unable to
reproduce the bug,
which in itself is a mystery I don't have time to solve :-)

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from 
Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.me
metrics.com/em
ailpolicy.html</a>
#3Maksim Likharev
MLikharev@micropat.com
In reply to: Claudio Natoli (#1)
Re: Win32 bug fix

Compiled and tried,
seems much better, no more WAIT_FAIL errors.

but I have some questions:
1. Is there a any possibility to assign server log file ( option -l,--log )
when PG runs as a service,
I wasn't able to do that, dump everything into stderror or eventlog just
not convenient.

2. What is a theoretical and practical number of the concurrent connection?
I'm asking this question due to following, as right now each child
corresponds to
a thread, problem is thread reserves 1MB of V address space, so
technically we are talking about
2/3K of concurrent connections top, depending of Windows configuration
(3GB flag).
But 2K of connection still pretty decent number comparing to less then 60
for cygwin.

Thanks.

Show quoted text

-----Original Message-----
From: Claudio Natoli [mailto:claudio.natoli@memetrics.com]
Sent: Wednesday, August 25, 2004 9:20 PM
To: 'pgsql-patches@postgresql.org'
Cc: 'MLikharev@micropat.com'
Subject: Win32 bug fix

Could someone please eyeball the attached patch for errors and as a
correction for:
http://archives.postgresql.org/pgsql-bugs/2004-08/msg00307.php

Also, could someone (Maksim?) please reproduce the bug on
their system, and
then confirm that the patch corrects (as I seem unable to
reproduce the bug,
which in itself is a mystery I don't have time to solve :-)

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from
Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html&quot;&gt;http://www.me
metrics.com/em
ailpolicy.html</a>

#4Bruce Momjian
bruce@momjian.us
In reply to: Claudio Natoli (#1)
Re: Win32 bug fix

Patch applied. Thanks.

---------------------------------------------------------------------------

Claudio Natoli wrote:

Could someone please eyeball the attached patch for errors and as a
correction for:
http://archives.postgresql.org/pgsql-bugs/2004-08/msg00307.php

Also, could someone (Maksim?) please reproduce the bug on their system, and
then confirm that the patch corrects (as I seem unable to reproduce the bug,
which in itself is a mystery I don't have time to solve :-)

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#5Andreas Pflug
pgadmin@pse-consulting.de
In reply to: Maksim Likharev (#3)
Re: Win32 bug fix

Maksim Likharev wrote:

Compiled and tried,
seems much better, no more WAIT_FAIL errors.

but I have some questions:
1. Is there a any possibility to assign server log file ( option -l,--log )
when PG runs as a service,
I wasn't able to do that, dump everything into stderror or eventlog just
not convenient.

Use redirect_stderr.

Regards,
Andreas