Win32 Version patch

Dave Page wrote:

Evening committers,

Any ideas when Magnus' win32 version numbering patch is likely to get
applied?

Good question. Last I saw it it was quite large. Magnus, would you
post a new version so we can look it over again. I have no problem with
the binary file you suggested.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Dave Page wrote:

Evening committers,

Any ideas when Magnus' win32 version numbering patch is

likely to get

applied?

Good question. Last I saw it it was quite large. Magnus,
would you post a new version so we can look it over again. I
have no problem with the binary file you suggested.

Not really, since I haven't changed anything. But I can send the same
patch again. Last time I sent it there were no comments, so I knew of
nothing further to change. If there are more changes wanted, just tell
me what to change...

The only remaining discussion I recall was possibly moving of the ico
file to a different directory. Which I said I'd happily leave up to the
committers :-) If you tell me where you want it I can of course create a
new patch which uses those dirs... But I don't feel up to deciding about
new directories myself ;-)

//Magnus

-----Original Message-----
From: Magnus Hagander [mailto:mha@sollentuna.net]
Sent: 02 September 2004 09:47
To: Bruce Momjian; Dave Page
Cc: PostgreSQL-patches
Subject: RE: [PATCHES] Win32 Version patch

But I can send
the same patch again.

Line 398 should probably be

+ PGFILEDESC=PostgreSQL utility

And not

+ PGFILEDESC=PostgreSQL unitility

Good word though :-)

/D

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

If only psql uses the ico file right now, let's leave it in psql
directory. We can always move it later.

---------------------------------------------------------------------------

Magnus Hagander wrote:

Dave Page wrote:

Evening committers,

Any ideas when Magnus' win32 version numbering patch is

likely to get

applied?

Good question. Last I saw it it was quite large. Magnus,
would you post a new version so we can look it over again. I
have no problem with the binary file you suggested.

Not really, since I haven't changed anything. But I can send the same
patch again. Last time I sent it there were no comments, so I knew of
nothing further to change. If there are more changes wanted, just tell
me what to change...

The only remaining discussion I recall was possibly moving of the ico
file to a different directory. Which I said I'd happily leave up to the
committers :-) If you tell me where you want it I can of course create a
new patch which uses those dirs... But I don't feel up to deciding about
new directories myself ;-)

//Magnus

Content-Description: win32ver_2.patch

[ Attachment, skipping... ]

Content-Description: pgsql.ico

[ Attachment, skipping... ]

Content-Description: win32ver.rc

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Patch applied. Thanks.

I made the wording correction suggested by Dave Page.

Cleaned up patch attached. I think the impact is minimal as I renamed
some things and moved the binary description up to the top of the
Makefile so it looks like a comment.

---------------------------------------------------------------------------

Magnus Hagander wrote:

Dave Page wrote:

Evening committers,

Any ideas when Magnus' win32 version numbering patch is

likely to get

applied?

Good question. Last I saw it it was quite large. Magnus,
would you post a new version so we can look it over again. I
have no problem with the binary file you suggested.

Not really, since I haven't changed anything. But I can send the same
patch again. Last time I sent it there were no comments, so I knew of
nothing further to change. If there are more changes wanted, just tell
me what to change...

The only remaining discussion I recall was possibly moving of the ico
file to a different directory. Which I said I'd happily leave up to the
committers :-) If you tell me where you want it I can of course create a
new patch which uses those dirs... But I don't feel up to deciding about
new directories myself ;-)

//Magnus

Content-Description: win32ver_2.patch

[ Attachment, skipping... ]

Content-Description: pgsql.ico

[ Attachment, skipping... ]

Content-Description: win32ver.rc

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073