Xid in log_line_prefix

Started by Alvaro Herreraalmost 22 years ago4 messagespatches
Jump to latest
#1Alvaro Herrera
alvherre@dcc.uchile.cl

Patches,

This trivial patch adds the transaction Id to the list of escapes
available to log_line_prefix. (Note that I used the top transaction Id,
not the current subtransaction Id, which is clearly useless for PITR
purposes.)

One important question is what letter to use for this. It seemed to me
that the most obvious letter was "x". So I used that, and changed the
"postmaster and friends stop here" to "q".

I also thought of using %t, but that is already taken too.

Anyone has a better idea?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
Bob [Floyd] used to say that he was planning to get a Ph.D. by the "green
stamp method," namely by saving envelopes addressed to him as 'Dr. Floyd'.
After collecting 500 such letters, he mused, a university somewhere in
Arizona would probably grant him a degree. (Don Knuth)

Attachments:

xid_in_log_prefix.patctext/plain; charset=us-asciiDownload+22-8
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: Xid in log_line_prefix

Alvaro Herrera <alvherre@dcc.uchile.cl> writes:

This trivial patch adds the transaction Id to the list of escapes
available to log_line_prefix. (Note that I used the top transaction Id,
not the current subtransaction Id, which is clearly useless for PITR
purposes.)

Looks reasonable to me ...

regards, tom lane

#3Neil Conway
neilc@samurai.com
In reply to: Alvaro Herrera (#1)
Re: Xid in log_line_prefix

On Sat, 2004-09-11 at 13:44, Alvaro Herrera wrote:

This trivial patch adds the transaction Id to the list of escapes
available to log_line_prefix.

Patch applied to HEAD. Thanks.

Bruce, this patch was/is on the pending patches list. I don't know of a
way to remove items from that list myself -- can you remove it for me
when you get a chance?

-Neil

#4Bruce Momjian
bruce@momjian.us
In reply to: Neil Conway (#3)
Re: Xid in log_line_prefix

Neil Conway wrote:

On Sat, 2004-09-11 at 13:44, Alvaro Herrera wrote:

This trivial patch adds the transaction Id to the list of escapes
available to log_line_prefix.

Patch applied to HEAD. Thanks.

Bruce, this patch was/is on the pending patches list. I don't know of a
way to remove items from that list myself -- can you remove it for me
when you get a chance?

Done. I remove them when I see a commit. Do you need better access to
that mailbox file? It is on my ftp site.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073