logfile for psql patch update

Started by Nonameover 21 years ago4 messagespatches
Jump to latest
#1Noname
lsunley@mb.sympatico.ca

This update replaces the previous patch for the psql logfile option

The print.c routine is also built into src/bin/scripts

The ifdef USE_LOGFILE wrapper is to keep out compile errors when the
routine is linked into programs other than psql

Lorne

--
-----------------------------------------------------------
lsunley@mb.sympatico.ca
-----------------------------------------------------------

Attachments:

psql2.diffapplication/octet-stream; name=psql2.diffDownload+75-18
#2Bruce Momjian
bruce@momjian.us
In reply to: Noname (#1)
Re: logfile for psql patch update

This has been saved for the 8.1 release:

http:/momjian.postgresql.org/cgi-bin/pgpatches2

---------------------------------------------------------------------------

lsunley@mb.sympatico.ca wrote:

This update replaces the previous patch for the psql logfile option

The print.c routine is also built into src/bin/scripts

The ifdef USE_LOGFILE wrapper is to keep out compile errors when the
routine is linked into programs other than psql

Lorne

--
-----------------------------------------------------------
lsunley@mb.sympatico.ca
-----------------------------------------------------------

[ Type application/octet-stream treated as attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Bruce Momjian
bruce@momjian.us
In reply to: Noname (#1)
Re: logfile for psql patch update

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------
lsunley@mb.sympatico.ca wrote:

This update replaces the previous patch for the psql logfile option

The print.c routine is also built into src/bin/scripts

The ifdef USE_LOGFILE wrapper is to keep out compile errors when the
routine is linked into programs other than psql

Lorne

--
-----------------------------------------------------------
lsunley@mb.sympatico.ca
-----------------------------------------------------------

[ Type application/octet-stream treated as attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Bruce Momjian
bruce@momjian.us
In reply to: Noname (#1)
Re: logfile for psql patch update

lsunley@mb.sympatico.ca wrote:

This update replaces the previous patch for the psql logfile option

The print.c routine is also built into src/bin/scripts

The ifdef USE_LOGFILE wrapper is to keep out compile errors when the
routine is linked into programs other than psql

I have applied the psql -L logging patch, thanks, but I made a few changes.

Instead of using a Makefile flag, I properly isolated print.c by passing
in the log file descriptor. I had to modify printQuery() and
printTable() to pass the log file descriptor.

I see no need for the \set LOGFILE value --- it didn't allow you to
specify the log file name or turn on logging. I think the -L flag is
sufficient.

I modified the OS2 test so the WIN32 code is run. Please let me know if
that works.

The **** you used at the top and bottom of the query was similar to the
existing single-step printing style we already have, so it seemed OK.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Attachments:

/bjm/difftext/plainDownload+107-59