add regression test for #1433
This patch adds a regression test for the bug with domains and ALTER
TABLE that Tom fixed a few hours ago.
Barring any objections I'll apply this to HEAD by the end of the day.
-Neil
Attachments:
regression_with_no_oids-2.patchtext/x-patch; charset=ISO-8859-1; name=regression_with_no_oids-2.patchDownload+32-0
Neil Conway <neilc@samurai.com> writes:
This patch adds a regression test for the bug with domains and ALTER
TABLE that Tom fixed a few hours ago.
It might be better to make the tables TEMP tables --- there are some
regression tests that depend on the set of existing tables, IIRC.
Otherwise ok.
regards, tom lane
On Tue, 2005-01-25 at 11:56 +1100, Neil Conway wrote:
This patch adds a regression test for the bug with domains and ALTER
TABLE that Tom fixed a few hours ago.
Applied.
-Neil
On Mon, 2005-01-24 at 22:22 -0500, Tom Lane wrote:
It might be better to make the tables TEMP tables --- there are some
regression tests that depend on the set of existing tables, IIRC.
Otherwise ok.
True, although those kind of dependencies usually cause an obvious test
failure (which this patch doesn't cause). I've been thinking that
there's some value in keeping database objects creating by regression
tests around, so that we get better pg_dump coverage (a quick and dirty
pg_dump test is to dump the database created by "make installcheck" and
restore it). Admittedly this is pretty primitive, but it's better than
nothing.
[ Sorry for applying the patch already, I hadn't received your mail ]
-Neil