more fixes for making contrib null safe

Started by Kris Jurkaover 21 years ago5 messagespatches
Jump to latest
#1Kris Jurka
books@ejurka.com

This adds the strict function attribute to the places in contrib that
crash on null inputs.

Kris Jurka

Attachments:

contrib.nullsafe.patchtext/plain; charset=US-ASCII; name=contrib.nullsafe.patchDownload+56-56
#2Jon Jensen
jon@endpoint.com
In reply to: Kris Jurka (#1)
Re: more fixes for making contrib null safe

On Fri, 28 Jan 2005, Kris Jurka wrote:

This adds the strict function attribute to the places in contrib that
crash on null inputs.

Doesn't C need to be quoted? A few of those looked like this:

LANGUAGE C STRICT

but I thought it should be:

LANGUAGE 'C' STRICT

Is that right?

Jon

--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
Software development with Interchange, Perl, PostgreSQL, Apache, Linux, ...

#3Kris Jurka
books@ejurka.com
In reply to: Jon Jensen (#2)
Re: more fixes for making contrib null safe

On Sat, 29 Jan 2005, Jon Jensen wrote:

On Fri, 28 Jan 2005, Kris Jurka wrote:

This adds the strict function attribute to the places in contrib that
crash on null inputs.

Doesn't C need to be quoted? A few of those looked like this:

LANGUAGE C STRICT

This is perfectly legal:

http://developer.postgresql.org/docs/postgres/sql-createfunction.html

langname

The name of the language that the function is implemented in. May be
SQL, C, internal, or the name of a user-defined procedural language. For
backward compatibility, the name may be enclosed by single quotes.

Kris Jurka

#4Jon Jensen
jon@endpoint.com
In reply to: Kris Jurka (#3)
Re: more fixes for making contrib null safe

On Fri, 28 Jan 2005, Kris Jurka wrote:

Doesn't C need to be quoted? A few of those looked like this:

LANGUAGE C STRICT

This is perfectly legal:

http://developer.postgresql.org/docs/postgres/sql-createfunction.html

langname

The name of the language that the function is implemented in. May be
SQL, C, internal, or the name of a user-defined procedural language. For
backward compatibility, the name may be enclosed by single quotes.

Oh, ok. Good to know.

Thanks,
Jon

--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
Software development with Interchange, Perl, PostgreSQL, Apache, Linux, ...

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Kris Jurka (#1)
Re: more fixes for making contrib null safe

Kris Jurka <books@ejurka.com> writes:

This adds the strict function attribute to the places in contrib that
crash on null inputs.

Sounds good. Barring objections, I'll apply this to current and back
branches before we make the upcoming releases.

regards, tom lane