Re: submitted WIN1252 patches are buggy

I have added your new files to CVS and made a new patch for win1252
rather than using the ones you supplied, and it now works. I also added
regression tests. The patch is attached. I installed your new files
too, with a slight renaming of function names for consistency.

There are a few other cleanups in the patch as well.

Anyway, with these changes, initdb and the regression tests now pass.

Thanks for working on this.

---------------------------------------------------------------------------

Roland Volkmann wrote:

Hello Bruce,

the decision to kick out the win1252-support from version 8.0 was
absolutely correct: my patches were buggy!

Meanwhile I have the build environment for native win32 code, and I
could test the submitted patches. They don't work, so please delete what
I had sent to you privately on 05.12.04

I corrected the sources, and now I can build the win32 port of
PostgreSQL with WIN1252-support. But there is still a big problem where
I have no more ideas after having spent 3 days now without success.

initdb throws the following error regardless the selected charset:

FATAL: default conversion for WIN1250 to UNICODE already exists
child process was terminated by signal 1
initdb: removing data directory "D:/Programme/PostgreSQL/8.0.0-rc1/data"

When using grep to check all areas for "win1250" I cannot find a
duplicate declaration. Building the win32 port without the patches
doesn't show this issue.

Here is the overview of the modifications I use, current base is
snapshot from 16.12.04:

Directory of \doc\src\sgml\*

17.12.2004 2:12 29.040 charset.sgml (changed file)
17.12.2004 2:18 309.928 func.sgml (changed file)
----------------------------------------------------------------------------

Directory of \src\backend\utils\mb\*

14.12.2004 0:36 9.417 encnames.c (changed file)
14.12.2004 0:38 15.714 wchar.c (changed file)
----------------------------------------------------------------------------

Directory of \src\backend\utils\mb\conversion_procs\*

16.12.2004 3:37 10.793 Makefile (changed file)
----------------------------------------------------------------------------

Directory of \src\backend\utils\mb\conversion_procs\utf8_and_win1252\*

5.12.2004 3:28 475 Makefile (new file)
5.12.2004 3:28 1.897 utf8_and_win1252.c (new file)
----------------------------------------------------------------------------

Directory of \src\backend\utils\mb\Unicode\*

5.12.2004 3:28 2.563 utf8_to_win1252.map (new file)
8.12.2004 5:34 2.643 win1252_to_utf8.map (new file)
----------------------------------------------------------------------------

Directory of \src\bin\initdb\*

17.12.2004 1:27 61.231 initdb.c (changed file)
----------------------------------------------------------------------------

Directory of \src\Include\mb\*

14.12.2004 0:42 11.854 pg_wchar.h (changed file)
----------------------------------------------------------------------------

There are 3 ZIP files attached to this mail:
- new_files.zip
- changed_files.zip
- patches.zip (for changed files only)

If you would have some spare time, perhaps you can give me a hint where
to look for the (hopefully) last bug.

With best regards,

Roland.

[ application/x-zip-compressed is not supported, skipping... ]

[ application/x-zip-compressed is not supported, skipping... ]

[ application/x-zip-compressed is not supported, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073