HeapTupleSatisfiesUpdate result as enum

Started by Alvaro Herreraover 21 years ago3 messagespatches
Jump to latest
#1Alvaro Herrera
alvherre@dcc.uchile.cl

Hackers,

Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
enum, like they are for HeapTupleSatisfiesVacuum?

I tried and came up with this patch. If there are no objections, please
apply.

--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"El d�a que dejes de cambiar dejar�s de vivir"

Attachments:

htsu-cleanup.patchtext/plain; charset=us-asciiDownload+49-49
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: HeapTupleSatisfiesUpdate result as enum

Alvaro Herrera <alvherre@dcc.uchile.cl> writes:

Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
enum, like they are for HeapTupleSatisfiesVacuum?

History only (the enum result convention for HeapTupleSatisfiesVacuum is
much younger code, IIRC). Seems like a reasonable change to me.

regards, tom lane

#3Neil Conway
neilc@samurai.com
In reply to: Alvaro Herrera (#1)
Re: HeapTupleSatisfiesUpdate result as enum

Alvaro Herrera wrote:

Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
enum, like they are for HeapTupleSatisfiesVacuum?

Applied, thanks.

-Neil