Remove second argument from textToQualifiedNameList

Started by Jaime Casanovaover 21 years ago4 messagespatches
Jump to latest
#1Jaime Casanova
jcasanov@systemguards.com.ec

Hi,

i found out that the function textToQualifiedNameList doesn't use the
second argument it receive (caller). i suppose in the past was used
and now it is useless, if that is the case here is a patch removing.
Or are any reasons to keep that argument?

--
regards,
Jaime Casanova
(DBA: DataBase Aniquilator ;)

Attachments:

textToQualifiedNameList.patchtext/plain; name=textToQualifiedNameList.patchDownload+43-43
#2Neil Conway
neilc@samurai.com
In reply to: Jaime Casanova (#1)
Re: Remove second argument from textToQualifiedNameList

Jaime Casanova wrote:

i found out that the function textToQualifiedNameList doesn't use the
second argument it receive (caller). i suppose in the past was used
and now it is useless, if that is the case here is a patch removing.
Or are any reasons to keep that argument?

None that I can see. I'll apply the patch later today, barring any
objections.

-Neil

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#2)
Re: Remove second argument from textToQualifiedNameList

Neil Conway <neilc@samurai.com> writes:

Jaime Casanova wrote:

Or are any reasons to keep that argument?

None that I can see. I'll apply the patch later today, barring any
objections.

Looking at the 7.3 sources, the argument was used to support the
then-existing convention that an error message include the name
of the reporting routine. This does seem obsolete now.

regards, tom lane

#4Neil Conway
neilc@samurai.com
In reply to: Jaime Casanova (#1)
Re: Remove second argument from textToQualifiedNameList

Jaime Casanova wrote:

i found out that the function textToQualifiedNameList doesn't use the
second argument it receive (caller). i suppose in the past was used
and now it is useless, if that is the case here is a patch removing.
Or are any reasons to keep that argument?

Applied to HEAD. Thanks for the patch.

-Neil