Broken code in recent troff commit

Started by Tom Laneabout 21 years ago3 messagespatches
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

print.c line 1009:
fputs("\(rs", fout);

is sufficiently obviously wrong that even my ancient HPUX C compiler is
unhappy. I don't know troff, though, so I don't know if "\\(rs" was
meant or something else.

regards, tom lane

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: Broken code in recent troff commit

Tom Lane wrote:

print.c line 1009:
fputs("\(rs", fout);

is sufficiently obviously wrong that even my ancient HPUX C compiler is
unhappy. I don't know troff, though, so I don't know if "\\(rs" was
meant or something else.

Yea, fixed. \(rs is reverse slash.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Roger Leigh
rleigh@whinlatter.ukfsn.org
In reply to: Tom Lane (#1)
Re: Broken code in recent troff commit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom Lane <tgl@sss.pgh.pa.us> writes:

print.c line 1009:
fputs("\(rs", fout);

is sufficiently obviously wrong that even my ancient HPUX C compiler is
unhappy. I don't know troff, though, so I don't know if "\\(rs" was
meant or something else.

Sorry about that. I'm not sure why GCC didn't pick that up. Troff
uses "\(rs" to produce a backslash ("Right Slash"), so "\\(rs" will be
correct. I've double checked the rest of the diff, and that's the
only instance of a missing '\'.

Regards,
Roger

- --
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/&gt;

iD8DBQFCqI6wVcFcaSW/uEgRAvVKAKDLg7ndWV7qoTV3y+Cs8NA2xAXlPQCg9YfQ
OZSJZHnbPTtthHpslRQUf7U=
=cGHq
-----END PGP SIGNATURE-----