Unused MMCacheLock

Started by ITAGAKI Takahiroabout 21 years ago5 messagespatches

itagaki.takahiro@oss.ntt.co.jp

about 21 years ago

Hi,

Are there any reasons MMCacheLock has been left yet?
Did we forget to remove it when mm.c was removed?

*** lwlock.h	Sat Jun 18 07:32:50 2005
--- lwlock-nomm.h	Wed Jul 27 16:18:42 2005
***************
*** 33,39 ****
  	ProcArrayLock,
  	SInvalLock,
  	FreeSpaceLock,
- 	MMCacheLock,
  	WALInsertLock,
  	WALWriteLock,
  	ControlFileLock,
--- 33,38 ----

---
ITAGAKI Takahiro
NTT Cyber Space Laboratories

Neil Conway

neilc@samurai.com

about 21 years ago

In reply to: ITAGAKI Takahiro (#1)

Re: Unused MMCacheLock

ITAGAKI Takahiro wrote:

Are there any reasons MMCacheLock has been left yet?

Not as far as I can see -- good catch. Patch applied to HEAD.

-Neil

Tom Lane

tgl@sss.pgh.pa.us

about 21 years ago

In reply to: ITAGAKI Takahiro (#1)

Re: Unused MMCacheLock

ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp> writes:

Did we forget to remove it when mm.c was removed?

Yup :-(. Thanks for catching it.

regards, tom lane

Simon Riggs

simon@2ndQuadrant.com

about 21 years ago

In reply to: Neil Conway (#2)

Re: Unused MMCacheLock

On Wed, 2005-07-27 at 18:06 +1000, Neil Conway wrote:

ITAGAKI Takahiro wrote:

Are there any reasons MMCacheLock has been left yet?

Not as far as I can see -- good catch. Patch applied to HEAD.

Neil,

I thought you removed that in February? Or is my memory playing tricks?

Best Regards, Simon Riggs

Neil Conway

neilc@samurai.com

about 21 years ago

In reply to: Simon Riggs (#4)

Re: Unused MMCacheLock

Simon Riggs wrote:

I thought you removed that in February? Or is my memory playing tricks?

Not I -- Tom removed src/backend/storage/smgr/mm.c in February of '04,
but evidently forgot to remove the associated LWLock.

-Neil