display and expression of the home directory in Win32

Am Freitag, 6. Januar 2006 04:03 schrieb Hiroshi Saito:
[pg_config]

HOMEDIR = "C:/Documents and Settings/saito/Application Data/postgresql"

Where does this come from and what would it be good for?

-----Original Message-----
From: pgsql-patches-owner@postgresql.org
[mailto:pgsql-patches-owner@postgresql.org] On Behalf Of
Peter Eisentraut
Sent: 06 January 2006 11:07
To: pgsql-patches@postgresql.org
Cc: Hiroshi Saito
Subject: Re: [PATCHES] display and expression of the home
directory in Win32

Am Freitag, 6. Januar 2006 04:03 schrieb Hiroshi Saito:
[pg_config]

HOMEDIR = "C:/Documents and Settings/saito/Application

Data/postgresql"

Where does this come from and what would it be good for?

It's not always obvious on Windows where this directory is because apps
generally write their files there themselves, thus the user doesn't
necessarily even know it exists. Pgpass.conf (which we store there) is a
bit of odd case because it may be used by various front-end applications
or drivers and may need manual editting.

That's not to say I necessarily think it should be added to pg_config -
I could be persuaded either way.

Regards, Dave.

I receive an inquiry from a user frequently. Where is it
about a home directory in a place? Then, In offer of the
initial state of Windows, the place is hidden and is not
visible to a user. I considered what can be offered this way
and that. Then, using pg_config thinks that it is good.

This patch show a user a clear place. Please take this into
consideration.

F:\postgresql-8.1.2stable\src\bin\pg_config\Release>pg_config.exe
BINDIR = F:/postgresql-8.1.2stable/src/bin/pg_config/Release
DOCDIR =
INCLUDEDIR =
PKGINCLUDEDIR =
INCLUDEDIR-SERVER =
LIBDIR =
PKGLIBDIR =
LOCALEDIR =
MANDIR =
SHAREDIR =
SYSCONFDIR =
PGXS = /pgxs/src/makefiles/pgxs.mk
HOMEDIR = "C:/Documents and Settings/saito/Application
Data/postgresql"
VERSION = PostgreSQL 8.1.1

HOMEDIR is a very bad name for this variable, since it's *not* the home
directory. It could easily be confused. If we put it in, I definitly
think it should be called something else.. (USERCONFDIR based on that we
have SYSCONFDIR, perhaps?). Also, there is no reason not to include it
on Unix as well - it would actrually be much better to do that, in case
someone wants to write a script that relies on it.

I'm also not sure this really buys us buch. There is already an
environment variable that points to this (unless you've applied some
very unusual modifications to your windows installation, in which case
you probably know where to be looking anyway), and that is:

%APPDATA%\postgresql

dir "C:/Documents and Settings/saito/Application Data/postgresql"

This would then be:
dir "%APPDATA%\postgresql"

which is actually much easier to use than getting it from pg_config,
since you can use the environment variable in any command you want.

//Magnus

From: "Magnus Hagander"

HOMEDIR = "C:/Documents and Settings/saito/Application
Data/postgresql"
VERSION = PostgreSQL 8.1.1

HOMEDIR is a very bad name for this variable, since it's *not* the home
directory. It could easily be confused. If we put it in, I definitly
think it should be called something else.. (USERCONFDIR based on that we

Um, About a name, I think that it is right.

have SYSCONFDIR, perhaps?). Also, there is no reason not to include it
on Unix as well - it would actrually be much better to do that, in case
someone wants to write a script that relies on it.

It will be good to be clearly shown in all environments.

dir "C:/Documents and Settings/saito/Application Data/postgresql"

This would then be:
dir "%APPDATA%\postgresql"

which is actually much easier to use than getting it from pg_config,
since you can use the environment variable in any command you want.

Probably, there is a user who notices after the directory is shown.

Regards,
Hiroshi Saito