pg_ctl crash fix

Started by Magnus Haganderover 20 years ago5 messagespatches
Jump to latest
#1Magnus Hagander
magnus@hagander.net

pg_dump crashes on "unregister" when a data directory is not specified.
Even though a data directory is not required. Attached patch fixes that.

(There is a check a couple of rows up that specifically allow for
pg_data to be null with unregister, but then we try to use it without
checking if it is...)

//Magnus

Attachments:

pg_ctl_crash.patchapplication/octet-stream; name=pg_ctl_crash.patchDownload+11-11
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Magnus Hagander (#1)
Re: pg_ctl crash fix

Magnus Hagander wrote:

pg_dump crashes on "unregister" when a data directory is not
specified. Even though a data directory is not required. Attached
patch fixes that.

Fixed.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#3Magnus Hagander
magnus@hagander.net
In reply to: Peter Eisentraut (#2)
Re: pg_ctl crash fix

pg_dump crashes on "unregister" when a data directory is not
specified. Even though a data directory is not required. Attached
patch fixes that.

Fixed.

I don't have the back branches around right now, but I beleive at least
8.1 is affected. Probably 8.2 as well. Backpatch? I think so ;-) (and
probalby should've written that in the original mail, but forgot)

//Magnus

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Magnus Hagander (#3)
Re: pg_ctl crash fix

Magnus Hagander wrote:

I don't have the back branches around right now, but I beleive at
least 8.1 is affected. Probably 8.2 as well. Backpatch? I think so
;-) (and probalby should've written that in the original mail, but
forgot)

Done.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#5Magnus Hagander
magnus@hagander.net
In reply to: Peter Eisentraut (#4)
Re: pg_ctl crash fix

Magnus Hagander wrote:

I don't have the back branches around right now, but I beleive at
least 8.1 is affected. Probably 8.2 as well. Backpatch? I think so
;-) (and probalby should've written that in the original mail, but
forgot)

Done.

Thanks!

//Magnus