[PATCH] Explicit shell types

Started by Martijn van Oosterhoutover 20 years ago2 messagespatches
Jump to latest
#1Martijn van Oosterhout
kleptog@svana.org

Hi,

The only thing I considered wrong with the previous patch was it's odd
behaviour w.r.t. creation of types with the same name as one in
pg_catalog. However, Tom said this is not a serious issue given the
same problem exists in many other places in PostgreSQL.

So, I've added some regression tests and here is the patch for
inclusion.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/

Show quoted text

Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
tool for doing 5% of the work and then sitting around waiting for someone
else to do the other 95% so you can sue them.

Attachments:

shell.difftext/plain; charset=us-asciiDownload+138-67
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Martijn van Oosterhout (#1)
Re: [PATCH] Explicit shell types

Martijn van Oosterhout <kleptog@svana.org> writes:

The only thing I considered wrong with the previous patch was it's odd
behaviour w.r.t. creation of types with the same name as one in
pg_catalog. However, Tom said this is not a serious issue given the
same problem exists in many other places in PostgreSQL.

So, I've added some regression tests and here is the patch for
inclusion.

Applied with corrections --- most notably, you weren't setting the
dependencies correctly for a shell type, and referencing numeric
function OIDs from C code is not done.

regards, tom lane