Patch for - Change LIMIT/OFFSET to use int8

Started by Dhanaraj Mabout 20 years ago3 messagespatches
Jump to latest
#1Dhanaraj M
Dhanaraj.M@Sun.COM

I attach the patch for the following TODO item.

SQL COMMAND
* Change LIMIT/OFFSET to use int8

It passes all the regression tests and supports int8.
I am waiting for your review.

Thanks
Dhanaraj

Attachments:

limit-offset_patchtext/plain; name=limit-offset_patchDownload+76-23
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Dhanaraj M (#1)
Re: Patch for - Change LIMIT/OFFSET to use int8

Dhanaraj M <Dhanaraj.M@Sun.COM> writes:

I attach the patch for the following TODO item.
SQL COMMAND
* Change LIMIT/OFFSET to use int8

This can't possibly be correct. It doesn't even change the field types
in struct LimitState, for example. You've missed half a dozen places
in the planner that would need work, too.

regards, tom lane

#3Dhanaraj M
Dhanaraj.M@Sun.COM
In reply to: Tom Lane (#2)
Re: Patch for - Change LIMIT/OFFSET to use int8

I have made the changes appropriately. The regression tests passed.
Since I do not have enough resources, I could not test for a large number.
It works for a small table. If anybody tests for int8 value, it is
appreciated.
Also, it gives the following error msg, when the input exceeds the int8
limit.

ERROR: bigint out of range

I attach the patch. Pl. check it.
Thanks
Dhanaraj

Tom Lane wrote:

Show quoted text

Dhanaraj M <Dhanaraj.M@Sun.COM> writes:

I attach the patch for the following TODO item.
SQL COMMAND
* Change LIMIT/OFFSET to use int8

This can't possibly be correct. It doesn't even change the field types
in struct LimitState, for example. You've missed half a dozen places
in the planner that would need work, too.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Attachments:

limit-offset_patch.txttext/plain; name=limit-offset_patch.txtDownload+113-61