pg_backup_tar.c seems anerror by win32

Started by Hiroshi Saitoabout 20 years ago2 messagespatches
Jump to latest
#1Hiroshi Saito
z-saito@guitar.ocn.ne.jp

Hi Bruce-san.

Yesterday patch was inadequate....

pg_backup_tar.c: In function `tarOpen':
pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
pg_backup_tar.c:379: (Each undeclared identifier is reported only once
pg_backup_tar.c:379: for each function it appears in.)
pg_backup_tar.c:379: `S_IWRITE' undeclared (first use in this function)
pg_backup_tar.c: In function `_tarAddFile':
pg_backup_tar.c:1051: warning: comparison is always false due to limited range of data type
make[3]: *** [pg_backup_tar.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

This patch helps this.
Thanks.

Regards,
Hiroshi Saito

Attachments:

pg_backup_tar.c_patchapplication/octet-stream; name=pg_backup_tar.c_patchDownload+2-1
#2Bruce Momjian
bruce@momjian.us
In reply to: Hiroshi Saito (#1)
Re: pg_backup_tar.c seems anerror by win32

Hiroshi Saito wrote:

Hi Bruce-san.

Yesterday patch was inadequate....

pg_backup_tar.c: In function `tarOpen':
pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
pg_backup_tar.c:379: (Each undeclared identifier is reported only once
pg_backup_tar.c:379: for each function it appears in.)
pg_backup_tar.c:379: `S_IWRITE' undeclared (first use in this function)
pg_backup_tar.c: In function `_tarAddFile':
pg_backup_tar.c:1051: warning: comparison is always false due to limited range of data type
make[3]: *** [pg_backup_tar.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

This patch helps this.
Thanks.

Thanks. Patch applied to HEAD and 8.1.X.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +