XML syntax patch

Started by Bruce Momjianalmost 20 years ago8 messagespatches
Jump to latest
#1Bruce Momjian
bruce@momjian.us

I have received an update XML syntax patch from Nikolay (summer of code)
based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/pgpatches/xmltext/x-diffDownload+1156-10
#2Nikolay Samokhvalov
samokhvalov@gmail.com
In reply to: Bruce Momjian (#1)
Re: XML syntax patch

Two minor notes:
- this is "SQL/XML publishing functions" patch actually
- Initial author of the patch is Pavel Stehule, David added some
documentation (AFAIK)

On 9/5/06, Bruce Momjian <bruce@momjian.us> wrote:

I have received an update XML syntax patch from Nikolay (summer of code)
based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Best regards,
Nikolay

#3David Fetter
david@fetter.org
In reply to: Bruce Momjian (#1)
Re: XML syntax patch

On Mon, Sep 04, 2006 at 09:21:12PM -0400, Bruce Momjian wrote:

I have received an update XML syntax patch from Nikolay (summer of
code) based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

It was Pavel Stehule's patch. I just added a little bit of
documentation.

Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!

#4Bruce Momjian
bruce@momjian.us
In reply to: David Fetter (#3)
Re: XML syntax patch

David Fetter wrote:

On Mon, Sep 04, 2006 at 09:21:12PM -0400, Bruce Momjian wrote:

I have received an update XML syntax patch from Nikolay (summer of
code) based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

It was Pavel Stehule's patch. I just added a little bit of
documentation.

OK, thanks. I will make sure everyone gets credit.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#5Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#1)
Re: XML syntax patch

Am Dienstag, 5. September 2006 03:21 schrieb Bruce Momjian:

I have received an update XML syntax patch from Nikolay (summer of code)
based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

I've told you privately already, I think it would be a grave mistake to add
this now.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#6Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#5)
Re: XML syntax patch

Peter Eisentraut wrote:

Am Dienstag, 5. September 2006 03:21 schrieb Bruce Momjian:

I have received an update XML syntax patch from Nikolay (summer of code)
based on David Fetter's patch from 2005.

Comments? It would be nice to have for 8.2.

I've told you privately already, I think it would be a grave mistake to add
this now.

Uh, when? You had Nikolay review David's patch to see if it could be
made consistent enough so it could go into 8.2 and not conflict with the
additions in 8.3.

Now that I know, it will be pushed to 8.3 --- another feature that will
_not_ be in 8.2.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#7Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#6)
Re: XML syntax patch

Am Mittwoch, 6. September 2006 17:28 schrieb Bruce Momjian:

Uh, when? You had Nikolay review David's patch to see if it could be
made consistent enough so it could go into 8.2 and not conflict with the
additions in 8.3.

The only thing we could justify under the feature freeze regime is to add the
XML syntax into 8.2, operating on text data. That will change when the xml
type goes into 8.3. So we'd be adding a feature right now with the
announcement that the feature will break incompatibly in the next release.
That doesn't seem very useful to me.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

#8Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#7)
Re: XML syntax patch

Peter Eisentraut wrote:

Am Mittwoch, 6. September 2006 17:28 schrieb Bruce Momjian:

Uh, when? You had Nikolay review David's patch to see if it could be
made consistent enough so it could go into 8.2 and not conflict with the
additions in 8.3.

The only thing we could justify under the feature freeze regime is to add the
XML syntax into 8.2, operating on text data. That will change when the xml
type goes into 8.3. So we'd be adding a feature right now with the
announcement that the feature will break incompatibly in the next release.
That doesn't seem very useful to me.

Right, that is exactly what I remember, but you had Nikolay look at the
patch in case he could make it not break incompatibly in 8.3. Anyway,
patch shelved for 8.3. I just wanted to make sure I didn't miss an
email from you.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +