Regression tests

Magnus Hagander <magnus@hagander.net> writes:

Joachim Wieland attempted to post this patch, but it appears to be gone.

I trust the applied version will contain neither Windows newlines nor
non-English comments.

regards, tom lane

Tom Lane wrote:

Magnus Hagander <magnus@hagander.net> writes:

Joachim Wieland attempted to post this patch, but it appears to be gone.

I trust the applied version will contain neither Windows newlines nor
non-English comments.

Certainly would assume so. I haven't actually looked at the patch yet, I
just forwarded it.
(And I may well be responsible for the windows newlines - it may have
happened when I gzipped it on a windows box)

//Magnus

Magnus Hagander wrote:

Joachim Wieland attempted to post this patch, but it appears to be gone.
I tried a repost, and notivced it got rejected because it was >100kb.
Let me repeat previous objections that it really should be possible to
post a patch >100kb.
That said, here's a gzipped version.

Joachim, once it comes through, feel free to post whatever comments you
had in your original mail.

Here's an updated version of this patch. I reversed some parts of where
files went, which made the patch a whole lot smaller and easier to read,
and changed a couple of smaller things.

I have not yet looked at the actual ecpg parts (except noticed that they
are working on msvc at least), just the changes to main regression
tests. But I wanted to send off my new version for others to look at as
well before I do that.

This is still WIP, but comments appreciated.

//Magnus

On Sat, Jun 09, 2007 at 10:55:55PM +0200, Magnus Hagander wrote:

Magnus Hagander wrote:

Joachim Wieland attempted to post this patch, but it appears to be gone.
I tried a repost, and notivced it got rejected because it was >100kb.
Let me repeat previous objections that it really should be possible to
post a patch >100kb.
That said, here's a gzipped version.

Joachim, once it comes through, feel free to post whatever comments you
had in your original mail.

Here's an updated version of this patch. I reversed some parts of where
files went, which made the patch a whole lot smaller and easier to read,
and changed a couple of smaller things.

I have not yet looked at the actual ecpg parts (except noticed that they
are working on msvc at least), just the changes to main regression
tests. But I wanted to send off my new version for others to look at as
well before I do that.

This is still WIP, but comments appreciated.

I have applied a fairly well reworked version of this. The big thing is
that I moved the building of the pgc code out of the regression test driver
and into the build system using msbuild.

I also did a couple of minor fixes to the threading tests and such.

//Magnus

On Tue, Jun 12, 2007 at 01:16:32PM +0200, Magnus Hagander wrote:

I have applied a fairly well reworked version of this. The big thing is
that I moved the building of the pgc code out of the regression test driver
and into the build system using msbuild.

I also did a couple of minor fixes to the threading tests and such.

Thanks.

It seems you missed one file. make checktcp says:

pg_regress: could not open file "./ecpg_schedule_tcp" for reading

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

On Tue, Jun 12, 2007 at 02:25:24PM +0200, Michael Meskes wrote:

On Tue, Jun 12, 2007 at 01:16:32PM +0200, Magnus Hagander wrote:

I have applied a fairly well reworked version of this. The big thing is
that I moved the building of the pgc code out of the regression test driver
and into the build system using msbuild.

I also did a couple of minor fixes to the threading tests and such.

Thanks.

It seems you missed one file. make checktcp says:

pg_regress: could not open file "./ecpg_schedule_tcp" for reading

Oops, search/replace error. Fixed.

//Magnus