GUC temp_tablespaces (updated)

Started by Jaime Casanovaabout 19 years ago3 messagespatches
Jump to latest
#1Jaime Casanova
jcasanov@systemguards.com.ec

Hi,

This is an updated patch based on conversation on -hackers, basically
it adds a hint to the error thrown by DROP TABLESPACE when it's not
empty and there are temp files older than postmaster startup.

i had to remove PgRemoveTempFiles() to test the patch (what i dificult
task is to crash the server ;)

btw, I tried to send it to the same conversation but it never arrives
so i'm sending it to -patches.

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

Attachments:

temp_tablespaces-1.2.7.difftext/plain; charset=ANSI_X3.4-1968; name=temp_tablespaces-1.2.7.diffDownload+501-114
#2Bruce Momjian
bruce@momjian.us
In reply to: Jaime Casanova (#1)
Re: GUC temp_tablespaces (updated)

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Jaime Casanova wrote:

Hi,

This is an updated patch based on conversation on -hackers, basically
it adds a hint to the error thrown by DROP TABLESPACE when it's not
empty and there are temp files older than postmaster startup.

i had to remove PgRemoveTempFiles() to test the patch (what i dificult
task is to crash the server ;)

btw, I tried to send it to the same conversation but it never arrives
so i'm sending it to -patches.

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Jaime Casanova (#1)
Re: GUC temp_tablespaces (updated)

"Jaime Casanova" <systemguards@gmail.com> writes:

This is an updated patch based on conversation on -hackers,

Applied with revisions --- mostly cosmetic, but the permissions-checking
was a mess and the documentation updates lacked a lot too.

it adds a hint to the error thrown by DROP TABLESPACE when it's not
empty and there are temp files older than postmaster startup.

I didn't apply this part because it was 100% bogus. There never will be
any temp files older than postmaster startup. There might be some value
in complaining about files older than the last crash-restart, but that
time is not tracked anywhere AFAIR. I didn't see enough value in the
hint to worry about fixing it; I just took it out.

regards, tom lane