HOT version 18

Started by Tom Lanealmost 19 years ago5 messagespatches
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

I have completed a first review pass over all of the HOT patch, and am
now reasonably satisfied with coding style, APIs, etc. There are still
two or three areas that need discussion, which I'll start a separate
thread for on -hackers. In the meantime, here's some code for people to
test and poke at ...

regards, tom lane

#2Jaime Casanova
jcasanov@systemguards.com.ec
In reply to: Tom Lane (#1)
Re: HOT version 18

On 9/17/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:

I have completed a first review pass over all of the HOT patch, and am
now reasonably satisfied with coding style, APIs, etc. There are still
two or three areas that need discussion, which I'll start a separate
thread for on -hackers. In the meantime, here's some code for people to
test and poke at ...

regards, tom lane

this sql scripts make current cvs + patch to crash with this message
in the logs:

LOG: statement: update test set c2 = c2 -15 where current of q1;
TRAP: FailedAssertion("!(tuple_tableoid == table_oid)", File:
"execCurrent.c", Line: 128)
LOG: server process (PID 27599) was terminated by signal 6: Aborted
LOG: terminating any other active server processes

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

Attachments:

test-hot.sqlapplication/octet-stream; name=test-hot.sqlDownload
#3Pavan Deolasee
pavan.deolasee@gmail.com
In reply to: Jaime Casanova (#2)
Re: HOT version 18

On 9/18/07, Jaime Casanova <systemguards@gmail.com> wrote:

this sql scripts make current cvs + patch to crash with this message
in the logs:

Can you please check if the attached patch fixes the issue for you ?
It sets t_tableOid before returning a HOT tuple to the caller.

Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com

Attachments:

HOT-set-tableoid.patchtext/x-patch; name=HOT-set-tableoid.patchDownload+1-0
#4Boszormenyi Zoltan
zb@cybertec.at
In reply to: Pavan Deolasee (#3)
Re: HOT version 18

Hi,

Pavan Deolasee írta:

On 9/18/07, *Jaime Casanova* <systemguards@gmail.com
<mailto:systemguards@gmail.com>> wrote:

this sql scripts make current cvs + patch to crash with this message
in the logs:

Can you please check if the attached patch fixes the issue for you ?
It sets t_tableOid before returning a HOT tuple to the caller.

Thanks,
Pavan

I can confirm that the script crashed HOT v18 and your patch fixes it.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Geschwinde & Schönig GmbH
http://www.postgresql.at/

#5Jaime Casanova
jcasanov@systemguards.com.ec
In reply to: Boszormenyi Zoltan (#4)
Re: HOT version 18

On 9/18/07, Zoltan Boszormenyi <zb@cybertec.at> wrote:

Hi,

Pavan Deolasee írta:

On 9/18/07, *Jaime Casanova* <systemguards@gmail.com
<mailto:systemguards@gmail.com>> wrote:

this sql scripts make current cvs + patch to crash with this message
in the logs:

Can you please check if the attached patch fixes the issue for you ?
It sets t_tableOid before returning a HOT tuple to the caller.

Thanks,
Pavan

I can confirm that the script crashed HOT v18 and your patch fixes it.

yeah! it works fine for me now...

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook