txid cleanup

Started by Marko Kreenalmost 19 years ago4 messagespatches
Jump to latest
#1Marko Kreen
markokr@gmail.com

Per Tom comments, attached patch does following:

- Binary I/O support
- Use ActiveSnapshot instead of SerializableSnapshot
- Clarify function purposes
- remove dev targets from Makefile

There should not be any code depending on SerializableSnapshot,
if there is thats a bug that needs fixing. Fix is easy - use
SERIALIZABLE transaction isolation level.

Also - either Tom or Jan has changed the code to allow
xmin == xmax. Is such case really valid? In _recv
code I followed the style, but I was just wondering.

--
marko

Attachments:

txid.cleanup.diffapplication/octet-stream; name=txid.cleanup.diffDownload+112-24
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Marko Kreen (#1)
Re: txid cleanup

"Marko Kreen" <markokr@gmail.com> writes:

Also - either Tom or Jan has changed the code to allow
xmin == xmax. Is such case really valid?

Yes, at least in CVS HEAD.

regards, tom lane

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Marko Kreen (#1)
Re: txid cleanup

"Marko Kreen" <markokr@gmail.com> writes:

Per Tom comments, attached patch does following:
- Binary I/O support
- Use ActiveSnapshot instead of SerializableSnapshot
- Clarify function purposes
- remove dev targets from Makefile

Applied with some further editorialization.

regards, tom lane

#4Marko Kreen
markokr@gmail.com
In reply to: Tom Lane (#2)
Re: txid cleanup

On 10/11/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Marko Kreen" <markokr@gmail.com> writes:

Also - either Tom or Jan has changed the code to allow
xmin == xmax. Is such case really valid?

Yes, at least in CVS HEAD.

Aha, I had missed that.

Thanks for confirmation.

--
marko