archiver ps display

Started by Simon Riggsover 18 years ago3 messagespatches
Jump to latest
#1Simon Riggs
simon@2ndQuadrant.com

Now that we have set archiver messages to DEBUG levels, there's no easy
way of seeing what file we are on.

Patch to set ps display for archiver enclosed, intended for 8.3

Before archive_command
postgres: archiver process archiving 00000001000000000000000B

After archive_command
postgres: archiver process archived 00000001000000000000000B

So the behaviour of the startup process and archiver are now
symmetrical, allowing it to be used for replication monitoring.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

Attachments:

archive_ps_display.v1.patchtext/x-patch; charset=UTF-8; name=archive_ps_display.v1.patchDownload+9-0
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Simon Riggs (#1)
Re: archiver ps display

Simon Riggs <simon@2ndquadrant.com> writes:

Patch to set ps display for archiver enclosed, intended for 8.3

I think this is a good idea. However, experimentation here showed that
at least on some machines (like HPUX), there's a pretty tight limit
before ps cuts off the display, and the more verbose messages discussed
on -hackers cause the last few digits of the filename to be cut off.
Which makes the display just about entirely useless. So I went with
these messages:

archiving %s
last was %s
failed on %s

We might need to make it even briefer, perhaps

at: %s
last: %s
failed: %s

depending on reports from the field.

Applied patch attached.

regards, tom lane

#3Simon Riggs
simon@2ndQuadrant.com
In reply to: Tom Lane (#2)
Re: archiver ps display

On Mon, 2007-12-17 at 19:54 -0500, Tom Lane wrote:

Simon Riggs <simon@2ndquadrant.com> writes:

Patch to set ps display for archiver enclosed, intended for 8.3

I think this is a good idea. However, experimentation here showed that
at least on some machines (like HPUX), there's a pretty tight limit
before ps cuts off the display, and the more verbose messages discussed
on -hackers cause the last few digits of the filename to be cut off.

Yeh, there's some command to extend the display, but few people use it,
so we're better off with the shorter display, I think.

Which makes the display just about entirely useless. So I went with
these messages:

archiving %s
last was %s
failed on %s

Looks good to me. Thanks.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com