Removing NONSEG mode
I attach patch which remove nonsegment mode support. It was discussed during
last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
XFS) and it is not safe on any OS because each OS support more filesystems.
I added RELSEG option to the configure script to allow easily compile with
different segment size (on most filesystem 1T is safe value). As a bonus I added
also BLCKSZ to configure script. It is not important for this patch but it could
be useful e.g. for buildfarm testing with different BLCKSZ.
Patch requires to run autoconf and autoheader.
Zdenek
PS: --with-segsize=1/1024 allows set segsize to 1MB - good for testing
Attachments:
seg.patchtext/x-patch; name=seg.patchDownload+66-139
Zdenek Kotala wrote:
I attach patch which remove nonsegment mode support. It was discussed during
last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
XFS) and it is not safe on any OS because each OS support more filesystems.
Added to May commitfest, thanks.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
I attach patch which remove nonsegment mode support. It was discussed during
last commit fest. Nonsegment mode is possible uses only on couple of FS (ZFS,
XFS) and it is not safe on any OS because each OS support more filesystems.
Applied with revisions --- mostly, you missed updating the
documentation, but also I didn't like the "LL" constant you used in
RELSEG_SIZE. It's unportable and there might be unexpected side effects
from having the macro represent an int64 constant instead of an integer.
So I had configure do the arithmetic and emit an integer.
regards, tom lane