New flex warnings

Started by Peter Eisentrautabout 18 years ago2 messagespatches
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

With GCC 4.3, I get warnings from every flex scanner that 'input' is defined
but not used. This can be solved by adding %option noinput. I tested this
option with a current flex and with the old 2.5.4a; both accept it. See
attached patch. Does anyone see problems with this?

Attachments:

flex-noinput.patchtext/x-diff; charset=us-ascii; name=flex-noinput.patchDownload+6-0
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: New flex warnings

Peter Eisentraut <peter_e@gmx.net> writes:

With GCC 4.3, I get warnings from every flex scanner that 'input' is defined
but not used. This can be solved by adding %option noinput. I tested this
option with a current flex and with the old 2.5.4a; both accept it. See
attached patch. Does anyone see problems with this?

Hm, I wonder why we didn't see those before ... [ looks at code... ]
Oh: yyinput() recurses internally, so even though it's not called
from anywhere else, older gcc's don't realize it's really unreferenced.

I confirm 2.5.4 has the noinput option. Patch seems ok from here,

regards, tom lane