Regression test database name
For some experiments I wanted to run the regression tests using a different
database (possibly using pg_regress --dbname=), but the name "regression" is
hardcoded in a few places. It's trivial to fix, see attached patch. Quick
explanation: The fact that psql's \z prints the database name has always been
an inconsistency, so it's good to get rid of anyway. The majority of the
diff in prepare.out is whitespace differences. Objections?
Attachments:
regression-dbname.difftext/x-diff; charset=us-ascii; name=regression-dbname.diffDownload+75-75
Peter Eisentraut wrote:
For some experiments I wanted to run the regression tests using a different
database (possibly using pg_regress --dbname=), but the name "regression" is
hardcoded in a few places. It's trivial to fix, see attached patch. Quick
explanation: The fact that psql's \z prints the database name has always been
an inconsistency, so it's good to get rid of anyway. The majority of the
diff in prepare.out is whitespace differences. Objections?
Seems like a good idea to me. +1.
//Magnus
Hi,
Peter Eisentraut wrote:
For some experiments I wanted to run the regression tests using a different
database (possibly using pg_regress --dbname=), but the name "regression" is
hardcoded in a few places. It's trivial to fix, see attached patch. Quick
explanation: The fact that psql's \z prints the database name has always been
an inconsistency, so it's good to get rid of anyway. The majority of the
diff in prepare.out is whitespace differences. Objections?
Looks good from here, passed the regressions on my (pretty standard
debian unstable) box.
However, there were some issues applying the patch, probably related to
git's diff format (patch version 2.5.9):
patch: **** malformed patch at line 255: diff -ur
../cvs-pgsql/src/test/regress/sql/prepare.sql
./src/test/regress/sql/prepare.sql
For those who care, I've added the same patch in context diff format and
modulo whitespaces. :-)
+1 for the change per se.
Regards
Markus