pgbench minor fixes
Minor patch on pgbench
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.
2. pre-run cleanup step was DELETE FROM HISTORY then VACUUM HISTORY.
This is just a slow version of TRUNCATE HISTORY.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Attachments:
pgbench_minor.v1.patchtext/x-patch; charset=UTF-8; name=pgbench_minor.v1.patchDownload+8-8
Simon Riggs wrote:
Minor patch on pgbench
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.
How does this work with custom scripts?
Show quoted text
2. pre-run cleanup step was DELETE FROM HISTORY then VACUUM HISTORY.
This is just a slow version of TRUNCATE HISTORY.
On Sun, 6 Jul 2008, Russell Smith wrote:
Simon Riggs wrote:
Minor patch on pgbench
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.How does this work with custom scripts?
That's the initialization step. It creates the 4 tables, populates then,
then runs VACCUM ANALYZE. There is no notion of what script you'll end up
executing yet. If you have a truly custom script that works against other
data instead of the pgbench tables, you won't even be executing this
initialization bit.
--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD
On Sun, 2008-07-06 at 00:06 +1000, Russell Smith wrote:
Simon Riggs wrote:
Minor patch on pgbench
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.How does this work with custom scripts?
I don't think we can justify vacuuming every table in the database just
so we get any tables being used for one set of tests. Not in a utility
that many users have access to, not just superusers. If you use a custom
script you just need to write a pre-test script and run it with psql.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Simon Riggs <simon@2ndquadrant.com> writes:
On Sun, 2008-07-06 at 00:06 +1000, Russell Smith wrote:
Simon Riggs wrote:
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.How does this work with custom scripts?
I don't think we can justify vacuuming every table in the database just
so we get any tables being used for one set of tests.
Actually your point is that the -i option wouldn't be used anyway
with a custom script ...
regards, tom lane
Committed, commit fest page updated.
---------------------------------------------------------------------------
Simon Riggs wrote:
Minor patch on pgbench
1. -i option should run vacuum analyze only on pgbench tables, not *all*
tables in database.2. pre-run cleanup step was DELETE FROM HISTORY then VACUUM HISTORY.
This is just a slow version of TRUNCATE HISTORY.--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
[ Attachment, skipping... ]
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +