pgsql: Fix handling of copy_file_range() return value

Started by Peter Eisentraut27 days ago1 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Fix handling of copy_file_range() return value

Treat copy_file_range() return value of zero as an error: it indicates
that no bytes could be copied (perhaps the source file is shorter than
expected), and the existing retry loop would otherwise spin forever
since nwritten would never reach BLCKSZ.

The other uses of copy_file_range() in the tree don't have this
problem.

Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Yingying Chen <cyy9255@gmail.com>
Discussion: /messages/by-id/3208cf7a-c7f3-41eb-92f6-33cbeff4df40@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/994f770a0fd55dfdeb96d1d60d35545ba2d51480

Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c | 3 +++
1 file changed, 3 insertions(+)