pgsql: Fix handling of dropping a property not associated with the give

Started by Peter Eisentraut23 days ago1 messagescomitters

peter_e@gmx.net

23 days ago

Fix handling of dropping a property not associated with the given label

When dropping a property by name from a label, the code checked only
whether the property existed in the graph's property catalog. It did
not verify that the property was actually associated with the given
label, resulting in passing InvalidOid to performDeletion(). Fix it
by explicilty checking the label property association.

While at it also rearrange the code so as to avoid multiple ereport
calls for the same error in the same block.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: /messages/by-id/1DA5D52A-4AFA-426E-83F7-42ED974D682B@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/96418a6da9d0e120c30f9b6c2c2bd8bbb0a98d00

Modified Files
--------------
src/backend/commands/propgraphcmds.c | 47 +++++++++-------------
.../regress/expected/create_property_graph.out | 2 +
src/test/regress/sql/create_property_graph.sql | 1 +
3 files changed, 22 insertions(+), 28 deletions(-)