Add missing CustomPathMethods on typedefs.list
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253011psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 06:43 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t253011_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t253011_1 && git checkout t253011_1Patchset v1 (message #1) is on t253011_1
Hi,
While reading src/include/nodes/extensible.h, I noticed that
CustomPathMethods was not correctly indented; this was because its
declaration was missing on typedefs.list. The attached patch fixes this.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
"Matheus Alcantara" <matheusssilv97@gmail.com> writes:
While reading src/include/nodes/extensible.h, I noticed that
CustomPathMethods was not correctly indented; this was because its
declaration was missing on typedefs.list. The attached patch fixes this.
In the end, typedefs.list is a mechanically generated file: the
authoritative list is whatever our buildfarm says it is. So trying
to force things is not helpful, because the change won't survive to
the end of the dev cycle.
The reason CustomPathMethods is not showing up in the generated list
is that it is not used anywhere to declare an object (variable, field,
function parameter or result, etc). The only place in core code that
has occasion to reference it is struct CustomPath, but that does
const struct CustomPathMethods *methods;
so it's not actually referencing the typedef. So a persistent fix
for this would have to do something about that. I think under C11
rules it'd be okay for pathnodes.h to duplicate the typedef
declaration:
typedef struct CustomPathMethods CustomPathMethods;
...
const CustomPathMethods *methods;
but I didn't try it.
regards, tom lane